fix(search): route logged-out search to the Bluesky appview - #173
Open
rishibalakrishnan wants to merge 2 commits into
Open
fix(search): route logged-out search to the Bluesky appview#173rishibalakrishnan wants to merge 2 commits into
rishibalakrishnan wants to merge 2 commits into
Conversation
The atproto-proxy header is only honored by a PDS, so a logged-out agent talking to the appview directly kept its search reads on the home appview regardless of the routing flag. Use a Bluesky-hosted agent for those calls, and apply the routing opts to getSuggestedFeeds, which set its own headers and never picked them up.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Search reads can be routed to the Bluesky appview behind the
search_appview:routeflag. Theatproto-proxyheader that implements that routing is only honored by a PDS, so a logged-out agent — which talks to an appview directly — dropped the header and kept every search on the home appview no matter how the flag was set.Logged-out search, actor search, and typeahead now use a Bluesky-hosted agent when the flag routes to Bluesky. Authenticated calls are unchanged and keep using the proxy header, so results stay session-scoped.
getSuggestedFeedspassed its own headers object and never picked up the routing opts; it now merges them.Test plan
search_appview:routeoff and confirm both states fall back to the home appview