Fix image deploy#105
Closed
afbase wants to merge 3 commits into
Closed
Conversation
…libipld. 2. update pds dockerfile to borrow layering trick 3. tweak the workflow file for better description
…tion in debian build.
rudyfraser
reviewed
May 15, 2025
rudyfraser
left a comment
Member
There was a problem hiding this comment.
Any reason for those specific versions for Multihash and cid? Just wanna make sure I understand why we can't be on the latest version of those crates
Collaborator
Author
there is a dependency issue mismatch as |
This was referenced May 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
❯ cargo check -p rsky-firehose Checking rsky-firehose v0.2.0 (/Users/clint/src/bsky-code/rsky/rsky-firehose) error[E0308]: mismatched types --> rsky-firehose/src/main.rs:146:88 | 146 | ... let record_reader = Cursor::new(car_blocks.get(&cid).unwrap()); | --- ^^^^ expected `&CidGeneric<64>`, found `&Cid<64>` | | | arguments to this method are incorrect | note: two different versions of crate `cid` are being used; two types coming from two different versions of the same crate are different types even if they look the same --> /Users/clint/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/cid-0.11.1/src/cid.rs:70:1 | 70 | pub struct Cid<const S: usize> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this is the found type `cid::cid::Cid` | ::: /Users/user/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/cid-0.10.1/src/cid.rs:67:1 | 67 | pub struct Cid<const S: usize> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this is the expected type `CidGeneric` | ::: rsky-firehose/src/main.rs:5:5 | 5 | use libipld::Cid; | ------- one version of crate `cid` used here, as a dependency of crate `libipld_core` 6 | use rsky_lexicon::app::bsky::feed::like::Like; | ------------ one version of crate `cid` used here, as a dependency of crate `rsky_lexicon` = help: you can use `cargo tree` to explore your dependency tree note: method defined here --> /Users/user/.rustup/toolchains/nightly-2025-01-03-aarch64-apple-darwin/lib/rustlib/src/rust/library/std/src/collections/hash/map.rs:897:12 | 897 | pub fn get<Q: ?Sized>(&self, k: &Q) -> Option<&V> | ^^^ For more information about this error, try `rustc --explain E0308`. error: could not compile `rsky-firehose` (bin "rsky-firehose") due to 1 previous errorChanges