fix(docker): clone exact PR commit in firehose and jetstream-subscriber Dockerfiles#190
Open
afbase wants to merge 1 commit into
Open
fix(docker): clone exact PR commit in firehose and jetstream-subscriber Dockerfiles#190afbase wants to merge 1 commit into
afbase wants to merge 1 commit into
Conversation
…er Dockerfiles Same fix as rsky-pds: replace hardcoded git clone of origin/main with ARG COMMIT_SHA + git init/fetch/checkout so the workspace always reflects the exact commit under test. Also threads COMMIT_SHA through the workflow build-args for both the fork and non-fork build steps. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ARG COMMIT_SHAfix from fix(rsky-pds): clone exact PR commit so new workspace members are included #189 torsky-firehose/Dockerfileandrsky-jetstream-subscriber/Dockerfileorigin/main, which would fail if a PR added a new workspace member not yet on mainbuild-args: COMMIT_SHA=...to both build steps inrust.yml(the workflow change from fix(rsky-pds): clone exact PR commit so new workspace members are included #189 only lands on the feature branch; this brings it to main)Why
These three Dockerfiles share the same git-clone pattern. Any PR that adds a new
Cargo.tomlworkspace member would cause all of them to fail atcargo buildbecause the cloned workspace wouldn't include the new member directory.Test plan
docker-build (rsky-firehose)anddocker-build (rsky-jetstream-subscriber)pass on this PR🤖 Generated with Claude Code