feat: 🆕 Entitlements DB web UI in docs site#751
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds new functionality for entitlements in the IPSW DB web UI by introducing new models, database methods, and a GitHub Actions workflow to update the entitlements database. Key changes include:
- New model definitions for Entitlement, EntitlementKey, and EntitlementWebSearch along with related database query methods.
- Updates in various logging messages from “filesystem” to “FileSystem” for consistency.
- Package version bumps and configuration tweaks in Docusaurus and package.json, as well as a new GitHub workflow for updating the entitlements database.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| www/static/sqlite.worker.js | Contains generated worker code for sqlite with source map reference. |
| www/package.json | Updates Docusaurus and dependency versions; changes start script. |
| www/docusaurus.config.js | Adds future config flags and an entitlements nav link. |
| www/docs/guides/macho.md | Updates logging message to use “FileSystem” capitalization. |
| internal/search/search.go | Updates logging messages for scanning “FileSystem”. |
| internal/model/ent.go | New model file defining entitlements structures for DB and web search. |
| internal/db/sqlite.go | Adds new methods for creating, retrieving, and searching entitlements. |
| internal/commands/ent/ent.go | Updates logging messages for scanning “FileSystem” within entitlement scan. |
| .github/workflows/update-entitlements-db.yml | New workflow to automatically update the entitlements database. |
Comments suppressed due to low confidence (2)
internal/db/sqlite.go:213
- The join in SearchEntitlements references the table 'entitlement_keys', but the EntitlementKey model's TableName() method returns 'entitlement_keys_normalized'. Verify that this join targets the intended table or update the TableName for consistency.
dbQuery = dbQuery.Joins("JOIN entitlement_keys ON entitlement_keys.entitlement_id = entitlements.id")
internal/db/sqlite.go:214
- Ensure that the underlying SQLite environment supports the REGEXP operator or that a custom implementation/extension is configured, as SQLite does not enable REGEXP by default.
Where("entitlement_keys.key REGEXP ?", query.KeyPattern)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.