fix font rendering for magit v4.4.0+#21
Open
andycandy-dev wants to merge 3 commits intoblahgeek:masterfrom
Open
fix font rendering for magit v4.4.0+#21andycandy-dev wants to merge 3 commits intoblahgeek:masterfrom
andycandy-dev wants to merge 3 commits intoblahgeek:masterfrom
Conversation
by introducing high priority overlays
Author
Owner
|
Thank you so much for submitting the issue and the pull request. I do agree with you that using overlay to support diff section's highlighting does not seem to be the best option, especially for the "post-command-hook" part. I don't know a better way either. Also, maybe for the similar reason as the diff section, the faces of the HTML body are still missing. (see below. first image is the result of current PR. second image is the expected result)
I do hope we can find a better solution. Until then, I've pushed a quick fix d893429 to master that set |
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Magit v4.4.0 Compatibility Fix
Problem
After upgrading to Magit v4.4.0, emacs-pr-review lost:
Root Cause
Magit v4.4.0 changed from using
facetext properties tofont-lock-faceproperties for all text rendering inmagit-section-modebuffers.From Magit v4.4.0 changelog:
fixes #20
ok, I've been fighting my agent for a while now, this seems to legitimately fix fonts on both UI and diff sections.

I've introduced overlays, didn't find a better way to have support for syntax highlighting.
tested with magit@4.4.0 and magit@4.4.2 on doomemacs.