Skip to content

Proxy the review thumbnail#862

Closed
NickM-27 wants to merge 1 commit intomasterfrom
review-thumb-proxy
Closed

Proxy the review thumbnail#862
NickM-27 wants to merge 1 commit intomasterfrom
review-thumb-proxy

Conversation

@NickM-27
Copy link
Copy Markdown
Collaborator

This will make it easier to support notification images for reviews

CC @SgtBatten

@dermotduffy dermotduffy added the enhancement New feature or request label Mar 14, 2025
@SgtBatten
Copy link
Copy Markdown

So what will the notification api url need to be with this?

@NickM-27
Copy link
Copy Markdown
Collaborator Author

It would be /review_id}/{thumb_path} both of which are in the payload

@SgtBatten
Copy link
Copy Markdown

The full thumb path, e.g thumb_path: /media/frigate/clips/review/thumb-deck-1742356726.868855-3lbv4j.webp

I see your change includes stripping the /media/frigate from the front so will we end up with something like

"{{base_url}}/api/frigate/notifications/{{review_id}}/clips/review/thumb-deck-1742356726.868855-3lbv4j.webp"

Sorry if that's a dumb question.

@NickM-27
Copy link
Copy Markdown
Collaborator Author

NickM-27 commented Mar 19, 2025

Yep that's right, but you can leave the /media and just pass as is

@github-actions github-actions Bot added the Stale label Apr 23, 2025
@github-actions github-actions Bot closed this Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants