validate ssl option#867
Merged
NickM-27 merged 7 commits intoblakeblackshear:masterfrom Mar 20, 2025
nickwalchli:master
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #867 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 2189 2195 +6
=========================================
+ Hits 2189 2195 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
ready for review / further edits at your discretion (codeowners) |
NickM-27
approved these changes
Mar 20, 2025
|
This works as expected for login, but camera feeds do not work. I suspect this "skip SSL" flag needs to be available/disable SSL in more contexts. I posted the full error message in #808 Thanks for all your hard work! |
Collaborator
|
Camera feeds are not subject to the same authentication so that is unlikely. Edit: oh it's not the stream but the metadata request. Not sure why that wouldn't use the same logic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to allow users to disable ssl validation on their frigate servers as some (truenas users to name some) will have https with self signed certs
I'm not sure if this is everything required to fix, but should at least be a start that someone with more experience could finish.