Skip to content

validate ssl option#867

Merged
NickM-27 merged 7 commits intoblakeblackshear:masterfrom
nickwalchli:master
Mar 20, 2025
Merged

validate ssl option#867
NickM-27 merged 7 commits intoblakeblackshear:masterfrom
nickwalchli:master

Conversation

@nickwalchli
Copy link
Copy Markdown
Contributor

@nickwalchli nickwalchli commented Mar 19, 2025

This PR is to allow users to disable ssl validation on their frigate servers as some (truenas users to name some) will have https with self signed certs

I'm not sure if this is everything required to fix, but should at least be a start that someone with more experience could finish.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (57c98e8) to head (9604a10).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #867   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         2189      2195    +6     
=========================================
+ Hits          2189      2195    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nickwalchli
Copy link
Copy Markdown
Contributor Author

ready for review / further edits at your discretion (codeowners)

@NickM-27 NickM-27 linked an issue Mar 20, 2025 that may be closed by this pull request
@NickM-27 NickM-27 merged commit 4d714f3 into blakeblackshear:master Mar 20, 2025
6 checks passed
@RamblinWreck77
Copy link
Copy Markdown

This works as expected for login, but camera feeds do not work. I suspect this "skip SSL" flag needs to be available/disable SSL in more contexts. I posted the full error message in #808

Thanks for all your hard work!

@NickM-27
Copy link
Copy Markdown
Collaborator

NickM-27 commented Mar 23, 2025

Camera feeds are not subject to the same authentication so that is unlikely.

Edit: oh it's not the stream but the metadata request. Not sure why that wouldn't use the same logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support skipping TLS verification

3 participants