Skip to content

Added GFS NCEI historical analysis source - #446

Merged
blaylockbk merged 2 commits into
blaylockbk:mainfrom
vieramercado:feature/ncei-historical-analysis
Jun 30, 2025
Merged

Added GFS NCEI historical analysis source#446
blaylockbk merged 2 commits into
blaylockbk:mainfrom
vieramercado:feature/ncei-historical-analysis

Conversation

@vieramercado

Copy link
Copy Markdown
Contributor

Added the GFS NCEI Historical Analysis source which contains valid grib2 data from 2007-04-01 to 2020-05-15.

@blaylockbk

Copy link
Copy Markdown
Owner

Thanks!

@blaylockbk

blaylockbk commented Jun 26, 2025

Copy link
Copy Markdown
Owner

Only the Windows test is not passing for your test. I don't have a lot of time to dig into this right now, but it looks like an issue with cfgrib/eccodes on windows for the particular file. Not sure yet.

@vieramercado

Copy link
Copy Markdown
Contributor Author

Only the Windows test is not passing for your test. I don't have a lot of time to dig into this right now, but it looks like an issue with cfgrib/eccodes on windows for the particular file. Not sure yet.

Interesting, this is passing for Windows using Conda but not when using UV. I was able to replicate on my local Windows machine, since I initially tested just with Conda. But it is failing with UV.

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

errid = -67

    def raise_grib_error(errid):
        """
        Raise the GribInternalError corresponding to ``errid``.
        """
>       raise ERROR_MAP[errid](errid)
E       gribapi.errors.FunctionalityNotEnabledError: Functionality not enabled

.venv\Lib\site-packages\gribapi\errors.py:381: FunctionalityNotEnabledError
------------------------------------------------------------------------------------------ Captured stderr call ------------------------------------------------------------------------------------------
ECCODES ERROR   :  JPEG support not enabled. Please rebuild with -DENABLE_JPG=ON

The GitHub Action with Conda installed eccodes 2.41.0 while UV installed 2.42.0.
There is no 2.42.0 in the conda-forge channel at the time of this comment.

Another interesting fact is that eccodes should have ENABLE_JPG=ON by default, according to the installation page. But the error implies it has been turned off during compilation.

One last note, the pip eccodes library has not been tested on Windows. So it could be that conda is doing some extra installation of the eccodes libraries but UV is not doing the same installation.

I did try changing the versions of eccodes while testing with UV locally with no luck. I'm not sure why JPEG support is needed on the new test I added since its basically the same as the tests above for GFS. It must be something in the data that eccodes is trying to parse.

@vieramercado

Copy link
Copy Markdown
Contributor Author

I updated the unit test to use a different date. Dates prior to 2015-01-15 was throwing the eccodes error only when using UV on Windows.

@blaylockbk
blaylockbk merged commit 4f03dee into blaylockbk:main Jun 30, 2025
9 checks passed
@blaylockbk

Copy link
Copy Markdown
Owner

Thanks for digging into eccodes issue, and glad to see this feature added.

@vieramercado
vieramercado deleted the feature/ncei-historical-analysis branch June 30, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants