fix product validation - #462
Merged
Merged
Conversation
BANANAPEEL202
marked this pull request as draft
August 3, 2025 00:40
BANANAPEEL202
marked this pull request as ready for review
August 3, 2025 01:30
Owner
|
Thanks! I have vauge memories of placing the _validate statement in its particular place. But I don't see that this change failed any tests, so it must be fine. |
blaylockbk
approved these changes
Aug 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently, inputting an invalid product leads to a generic
keyerrorby calling
_validate()earlier, we can throw a more useful assertion error: