Validate HTTP Range responses in subset downloads - #521
Conversation
|
Thx again jacob1299! I am very happy to inform you that I have resolved the issue by sync'ing the installed python packages on my laptop to those installed on my Desktop, now the variable-subset downloading is working as expected on my laptop as well. Thank you so much again for your help and developing the Herbie package and I apologize for the "false alarm" in this specific regard (i.e. not working on my laptop but working on my desktop.). The current variable-subset downloading in your Herbie package will definitely significant improve my project's efficiency, it would be even better if it can do spatial subset downloading simultaneously (along with variable-subset). Have a great day! |
|
Nice fix. I can see the need for this check. I'll try to get this merged when I have a chance to test it myself. |
Glad to hear it's working as expected, and you're very welcome! |
Summary
stream=Trueso multi-GB responses are never downloaded into memory on failureRuntimeErrorif Range requests are not honoredRef #514
Test plan
test_subset_range_validation.pyvalidates RuntimeError on non-206