Skip to content

Updates and additions to Canadian Models - #528

Merged
blaylockbk merged 5 commits into
blaylockbk:mainfrom
karlwx:add-canadian-ensembles
Apr 20, 2026
Merged

Updates and additions to Canadian Models#528
blaylockbk merged 5 commits into
blaylockbk:mainfrom
karlwx:add-canadian-ensembles

Conversation

@karlwx

@karlwx karlwx commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

A number of changes and additions related to the Canadian models:

  • Added GEPS and REPS model templates
  • Modified URL structure of gdps and rdps to match the new conventions
  • Ensured product and level name listings were accurate across all Canadian model templates
  • Updated eccc model notebooks

Down the road, I'd like to improve variable/level discovery for these models, but that would be a separate PR. That might involve something along the lines of scraping the directories to create a dataframe in the same format returned by H.inventory().

@blaylockbk

Copy link
Copy Markdown
Owner

This is awesome. Thanks!

I don't know why the tests struggle for the Canadian models. I'll probably just let it pass if they don't run when I retrigger it.

@blaylockbk

Copy link
Copy Markdown
Owner

Down the road, I'd like to improve variable/level discovery for these models, but that would be a separate PR. That might involve something along the lines of scraping the directories to create a dataframe in the same format returned by H.inventory().

This is a great idea. So, you mean, "for models that have 1 field per file (like Canadian and Navy), build an "inventory" from the directory listing page."


Side note: I've (slowly) been experimenting with a new "version 2" of Herbie's core: #504. You might see if your idea fit better into that architecture than the current implementation. That, of course, is very much a work in progress.

@karlwx

karlwx commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

I don't know why the tests struggle for the Canadian models. I'll probably just let it pass if they don't run when I retrigger it.

Not sure why the Canadian tests fail on here. I ran that particular test on my local system and it worked.

This is a great idea. So, you mean, "for models that have 1 field per file (like Canadian and Navy), build an "inventory" from the directory listing page."

Yep! That's what I was envisioning. That'll probably take some more planning to execute, so I'll take a look at it over the summer.

@blaylockbk
blaylockbk merged commit be8aeba into blaylockbk:main Apr 20, 2026
3 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants