Updates and additions to Canadian Models - #528
Conversation
|
This is awesome. Thanks! I don't know why the tests struggle for the Canadian models. I'll probably just let it pass if they don't run when I retrigger it. |
This is a great idea. So, you mean, "for models that have 1 field per file (like Canadian and Navy), build an "inventory" from the directory listing page." Side note: I've (slowly) been experimenting with a new "version 2" of Herbie's core: #504. You might see if your idea fit better into that architecture than the current implementation. That, of course, is very much a work in progress. |
Not sure why the Canadian tests fail on here. I ran that particular test on my local system and it worked.
Yep! That's what I was envisioning. That'll probably take some more planning to execute, so I'll take a look at it over the summer. |
A number of changes and additions related to the Canadian models:
Down the road, I'd like to improve variable/level discovery for these models, but that would be a separate PR. That might involve something along the lines of scraping the directories to create a dataframe in the same format returned by
H.inventory().