Fix Postgresql CSV import for older versions.#487
Fix Postgresql CSV import for older versions.#487giladarnold wants to merge 1 commit intoblaze:masterfrom
Conversation
Postresql's COPY command syntax has changed from 8.x to 9.x. odo uses the new syntax, which produces a syntax error when running against 8.x and older. Below is a patch that probes the database version and applies the correct syntax. It also fixes a (suspected) bug in how encoding is inferred.
giladarnold
force-pushed
the
fix-psql-import-csv
branch
from
22b4c6f to
8f1bf9a
Compare
llllllllll
left a comment
llllllllll
left a comment
There was a problem hiding this comment.
Sorry it has taken so long to get to this. We recently made a change to use COPY FROM STDIN for a big performance win. Do you think you could rebase against those changes and possibly add them to the pg 8 branch if it makes sense?
| ), | ||
| **kwargs | ||
| ) | ||
| postgres_version = element.bind.execute('select version()').scalar() |
There was a problem hiding this comment.
I am worried about the perf penalty we will pay to check this on every insert. What do you think about creating a WeakKeyDictionary from bind to version? This will let us save these checks across calls.
| escapechar=element.escapechar, | ||
| header=element.header, | ||
| encoding=element.encoding or element.bind.execute( | ||
| 'show client_encoding' |
There was a problem hiding this comment.
We could probably also memoize the encoding if we are caching the version.
| ) | ||
| postgres_version = element.bind.execute('select version()').scalar() | ||
| if int(postgres_version.split()[1].split('.')[0]) >= 9: | ||
| return compiler.process( |
There was a problem hiding this comment.
in order to make this easier to follow, what do you think about breaking these two calls into helper functions like _process_pg_8_or_lower or process_pg_9_and_greater?
2 participants
Postresql's COPY command syntax has changed from 8.x to 9.x. odo uses
the new syntax, which produces a syntax error when running against 8.x
and older. Below is a patch that probes the database version and applies
the correct syntax. It also fixes a (suspected) bug in how encoding is
inferred.