Skip to content

Added MP.variable#13

Open
ecboghiu wants to merge 1 commit intoblegat:masterfrom
ecboghiu:MPvariable
Open

Added MP.variable#13
ecboghiu wants to merge 1 commit intoblegat:masterfrom
ecboghiu:MPvariable

Conversation

@ecboghiu
Copy link

@ecboghiu ecboghiu commented Jun 5, 2020

New pull request, I'll close the old one, check if everything is ok now. Sorry about the mess, I'm still learning git

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #13 into master will increase coverage by 9.20%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   64.36%   73.56%   +9.20%     
==========================================
  Files           5        5              
  Lines         188      227      +39     
==========================================
+ Hits          121      167      +46     
+ Misses         67       60       -7     
Impacted Files Coverage Δ
src/operators.jl 89.85% <66.66%> (+9.85%) ⬆️
src/monom-set.jl 78.94% <0.00%> (+2.47%) ⬆️
src/CondensedMatterSOS.jl 84.61% <0.00%> (+4.61%) ⬆️
src/types.jl 81.81% <0.00%> (+8.23%) ⬆️
src/sequences.jl 47.88% <0.00%> (+11.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fde91a7...b9f74e0. Read the comment docs.

@blegat
Copy link
Owner

blegat commented Jun 5, 2020

No problem, didn't you also have tests ?

@ecboghiu
Copy link
Author

ecboghiu commented Jun 5, 2020

No problem, didn't you also have tests ?

The tests I had have been covered under "monomials and terms" and "single site" test sets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants