spam reporting

[komarov]

Spam reporting is available for trusted users (org members) via a button on a
spammer's profile page;
processing is done automatically using a new cron task process_spam_reports;
a new section Site Administration > Identity & Access > Spam Reports.

[brechtvl]

I only superficially tested it and skimmed the code so far.

Is the plan to upstream this at some point, or just as a local change? If we wanted to upstream this eventually I would have various comments, but probably that's not the plan for now?

It would be good to fix the errors reported by make lint. I like to run that on our patches to catch issues.

[brechtvl]

Also would be good to run make fmt.

[komarov]

sorry for potential confusion with the force push: all previous commits are combined in one, followups are done as commits on top

[komarov]

Is the plan to upstream this at some point, or just as a local change? If we wanted to upstream this eventually I would have various comments, but probably that's not the plan for now?

I got an impression that gitea is currently not looking for a site-wide moderation mechanism, and that they prefer to delegate it to org members.

I think this to some extent contradicts the direction we are taking, so I don't think this exact approach would ever land upstream to be honest.

[komarov]

I couldn't find a good way to integrate with the existing notification system, as all notifications must be linked to some other object (comment/repo/etc). I have added a simple indicator that is shown to admins when there are pending reports, it is also a link to the corresponding page:

[komarov]

Admin view of the profile:

Trusted user's view:

[brechtvl]

Seems to work fine overall. I think it's polished enough for us, only have some smaller comments left.

[komarov]

All outstanding remarks were incorporated in the latest commits, please take another look.

[brechtvl]

Thanks, looks good now.

[komarov]

Ok, i'll update the patch PR now. Thank you for the review!