fix(replay): keep production semantic maps local - #24
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts viewport-semantics behavior so that production captures can still build semantic maps locally for tap resolution, while semantic map/snapshot event emission remains exploration-only to avoid uploading semantic-node text in lean production sessions. It also bumps the Tugboat SDK version to 0.4.1 and documents the privacy behavior.
Changes:
- Gate
viewport_semantic_mapandscroll_semantic_snapshotevent emission to exploration only (production keeps local tap-resolution semantics). - Update/extend tests to assert production emits no semantic map/snapshot events even in “full” modes, while still producing tap semantic resolution data.
- Bump SDK/package version to 0.4.1 and document the production privacy semantics behavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/tugboat/lib/src/replay_config.dart | Updates viewport-semantics policy resolution to disable semantic event emission/debug logs outside exploration while keeping engine enabled. |
| packages/tugboat/lib/src/viewport_semantic_mode.dart | Clarifies mode documentation: “full” is exploration-emitting; production treats it as tap-resolution-only. |
| packages/tugboat/lib/src/controller.dart | Minor formatting/comment adjustment around exploration-only inventory/map emission context. |
| packages/tugboat/test/viewport_semantic_policy_test.dart | Extends policy tests to assert production never emits semantic events/debug logs even with full modes. |
| packages/tugboat/test/viewport_semantic_map_test.dart | Updates widget tests to assert production emits no semantic map/snapshot events, but still includes tap semantic resolution. |
| packages/tugboat/pubspec.yaml | Version bump to 0.4.1. |
| packages/tugboat/lib/src/sdk_version.dart | Keeps internal SDK version constant in sync with pubspec (0.4.1). |
| packages/tugboat/CHANGELOG.md | Documents production viewport-semantics staying local and exploration-only semantic event emission. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Chinmay-KB
force-pushed
the
fix/production-semantic-map-policy
branch
from
July 25, 2026 19:21
26d2eaa to
382af7b
Compare
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification