Skip to content

fix(replay): keep production semantic maps local - #24

Merged
Chinmay-KB merged 2 commits into
mainfrom
fix/production-semantic-map-policy
Jul 25, 2026
Merged

fix(replay): keep production semantic maps local#24
Chinmay-KB merged 2 commits into
mainfrom
fix/production-semantic-map-policy

Conversation

@Chinmay-KB

Copy link
Copy Markdown
Collaborator

Summary

  • keep viewport semantic map and scroll semantic snapshot event emission exploration-only
  • allow production to keep building local semantic maps for tap resolution without uploading map payloads
  • bump tugboat to 0.4.1 and document the production privacy behavior

Verification

  • dart format packages/tugboat/lib/src/controller.dart packages/tugboat/lib/src/replay_config.dart packages/tugboat/lib/src/viewport_semantic_mode.dart packages/tugboat/test/viewport_semantic_map_test.dart packages/tugboat/test/viewport_semantic_policy_test.dart
  • flutter analyze lib/src/controller.dart lib/src/replay_config.dart lib/src/viewport_semantic_mode.dart lib/src/sdk_version.dart test/sdk_version_test.dart test/viewport_semantic_map_test.dart test/viewport_semantic_policy_test.dart
  • flutter test test/sdk_version_test.dart test/viewport_semantic_policy_test.dart test/viewport_semantic_map_test.dart

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts viewport-semantics behavior so that production captures can still build semantic maps locally for tap resolution, while semantic map/snapshot event emission remains exploration-only to avoid uploading semantic-node text in lean production sessions. It also bumps the Tugboat SDK version to 0.4.1 and documents the privacy behavior.

Changes:

  • Gate viewport_semantic_map and scroll_semantic_snapshot event emission to exploration only (production keeps local tap-resolution semantics).
  • Update/extend tests to assert production emits no semantic map/snapshot events even in “full” modes, while still producing tap semantic resolution data.
  • Bump SDK/package version to 0.4.1 and document the production privacy semantics behavior.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/tugboat/lib/src/replay_config.dart Updates viewport-semantics policy resolution to disable semantic event emission/debug logs outside exploration while keeping engine enabled.
packages/tugboat/lib/src/viewport_semantic_mode.dart Clarifies mode documentation: “full” is exploration-emitting; production treats it as tap-resolution-only.
packages/tugboat/lib/src/controller.dart Minor formatting/comment adjustment around exploration-only inventory/map emission context.
packages/tugboat/test/viewport_semantic_policy_test.dart Extends policy tests to assert production never emits semantic events/debug logs even with full modes.
packages/tugboat/test/viewport_semantic_map_test.dart Updates widget tests to assert production emits no semantic map/snapshot events, but still includes tap semantic resolution.
packages/tugboat/pubspec.yaml Version bump to 0.4.1.
packages/tugboat/lib/src/sdk_version.dart Keeps internal SDK version constant in sync with pubspec (0.4.1).
packages/tugboat/CHANGELOG.md Documents production viewport-semantics staying local and exploration-only semantic event emission.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/tugboat/CHANGELOG.md
@Chinmay-KB
Chinmay-KB force-pushed the fix/production-semantic-map-policy branch from 26d2eaa to 382af7b Compare July 25, 2026 19:21
@Chinmay-KB
Chinmay-KB merged commit 400b0c5 into main Jul 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants