Emit overlay identity and presentation parent on route_change - #49
Closed
Chinmay-KB wants to merge 2 commits into
Closed
Emit overlay identity and presentation parent on route_change#49Chinmay-KB wants to merge 2 commits into
Chinmay-KB wants to merge 2 commits into
Conversation
Split routeName/routeType/routeNamed without changing fromRoute, route, or navigation. Classify overlays as page|sheet|dialog|popup|unknown, record presentedOver/hostPage and a bounded routeStack, copy cause fingerprints from claimed taps, and capture overlay after-frames under exploration screenshot suppression. Co-authored-by: Chinmay Kabi <chinmay@blend.to>
Claim-time snapshots miss tap target fingerprints that resolve after pointer-up. Refresh causeTargetFingerprint and causeGesture from the claimed interaction when the event is published. Widget tests now observe /home before overlay pushes and avoid inventing hostPageRoute when the initial page was not recorded. Co-authored-by: Chinmay Kabi <chinmay@blend.to>
|
Folded into #47 (native-capture branch) so overlay identity and native CPU land on one PR. Closing this duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Manifest (visual app map) cannot nest overlays under the screen that opened them. Unnamed sheets collapsed to
ModalBottomSheetRoute<void>,overlayKindcalled bottom sheetsmodal, and exploration screenshot suppression dropped overlay after-frames when there was no claimed tap.This change is additive.
fromRoute,route, andnavigationkeep their existing meaning. The SDK does not inventRouteSettings.nameor product CTA copy.What
On every
route_change:routeName/routeType/routeNamed(and matchingfrom*)overlayKind:page | sheet | dialog | popup | unknown(sheets aresheet, notmodal)presentedOver*(route immediately below on the same navigator) andhostPage*(walk down tooverlayKind == page, then parent navigators)routeStack(max 16,routeStackTruncatedwhen trimmed)causeTargetFingerprint/causeGesturefrom the claimed interaction at emit time (claim-time snapshots miss post-pointer-up target resolution)causeEventId != nulloroverlayKind != pagePresentation parent and
hostPage*are omitted on page pushes, pops, and when the observer never recorded the underlying page. The SDK does not invent/home.Paywall → unnamed sheet
Tests
routeStack, claimed cause fingerprint, and overlay capture under exploration suppressionrouteNamed: falseincluded)sheet/dialogkinds without inventing an unobserved host pagePackage version is
0.8.13. Route-change schema version stays2.Full
packages/tugboatsuite: 376 tests passed.