Skip to content

MB-71131: Support file writer callbacks for trained index#2379

Merged
Thejas-bhat merged 8 commits into
masterfrom
encryptTrainedIndex
Jul 16, 2026
Merged

MB-71131: Support file writer callbacks for trained index#2379
Thejas-bhat merged 8 commits into
masterfrom
encryptTrainedIndex

Conversation

@Thejas-bhat

@Thejas-bhat Thejas-bhat commented Jul 9, 2026

Copy link
Copy Markdown
Member
  • implement the fileWriterIDs and removeFileWriterIDs APIs which fetch and remove the file writer IDs/keys corresponding to the trained segment.
  • refactor the request handling + ack mechanism of the trainLoop()
  • update the destination index's bolt with the trained sample count, for consistent stats

@Thejas-bhat
Thejas-bhat force-pushed the encryptTrainedIndex branch from bf18138 to ef384dd Compare July 9, 2026 16:54
@coveralls

coveralls commented Jul 9, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 52.308% (-0.02%) from 52.323% — encryptTrainedIndex into master

Comment thread index/scorch/train_vector.go Outdated
Comment thread index/scorch/train_vector.go Outdated
Comment thread index/scorch/train_vector.go Outdated
@Thejas-bhat
Thejas-bhat marked this pull request as draft July 13, 2026 20:43
@Thejas-bhat
Thejas-bhat marked this pull request as ready for review July 14, 2026 02:34
@Thejas-bhat
Thejas-bhat requested a review from Likith101 July 14, 2026 02:34
Likith101
Likith101 previously approved these changes Jul 15, 2026
Comment thread index/scorch/train_vector.go Outdated
maneuvertomars
maneuvertomars previously approved these changes Jul 16, 2026
@Thejas-bhat
Thejas-bhat merged commit eea04eb into master Jul 16, 2026
10 of 11 checks passed
@Thejas-bhat
Thejas-bhat deleted the encryptTrainedIndex branch July 16, 2026 16:22
ns-codereview pushed a commit to couchbase/cbft that referenced this pull request Jul 16, 2026
bleve PR: blevesearch/bleve#2379

Change-Id: Ideeae368d1a703e67e307a859f2ebd3cddee5173
Reviewed-on: https://review.couchbase.org/c/cbft/+/248926
Reviewed-by: <thejas.orkombu@couchbase.com>
Tested-by: <thejas.orkombu@couchbase.com>
Well-Formed: Build Bot <build@couchbase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants