Skip to content

ci(publish): use windows-latest and powershell for windows builds#405

Merged
wolf31o2 merged 1 commit intomainfrom
ci/publish-windows-native
Apr 19, 2025
Merged

ci(publish): use windows-latest and powershell for windows builds#405
wolf31o2 merged 1 commit intomainfrom
ci/publish-windows-native

Conversation

@wolf31o2
Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Chris Gianelloni <wolf31o2@blinklabs.io>
@wolf31o2 wolf31o2 requested a review from a team as a code owner April 18, 2025 16:36
@wolf31o2 wolf31o2 requested review from Copilot and removed request for a team April 18, 2025 16:36
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the CI pipeline for publishing releases by incorporating Windows-specific steps using windows-latest and PowerShell. Key changes include:

  • Adding a global environment variable (APPLICATION_NAME) for consistent usage across steps.
  • Introducing Windows-specific workflow steps for setting the release tag, building the binary, signing the binary, uploading release assets, and attesting the build.
  • Modifying the matrix to include windows runners and using PowerShell (pwsh) commands for Windows tasks.
Comments suppressed due to low confidence (2)

.github/workflows/publish.yml:144

  • Consider using a consistent variable naming convention between Windows and non-Windows steps (e.g., consistently use 'filename' instead of mixing '$filename' and '_filename') to improve code clarity.
          $filename = "${{ env.APPLICATION_NAME }}.exe"

.github/workflows/publish.yml:148

  • Ensure that the PowerShell line continuation character (`) is supported in your target PowerShell versions and behaves as expected; testing on the specific environments is recommended.
          java -jar jsign.jar `

@wolf31o2 wolf31o2 merged commit 30aad33 into main Apr 19, 2025
8 checks passed
@wolf31o2 wolf31o2 deleted the ci/publish-windows-native branch April 19, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants