ci(publish): use windows-latest and powershell for windows builds#405
Merged
ci(publish): use windows-latest and powershell for windows builds#405
Conversation
Signed-off-by: Chris Gianelloni <wolf31o2@blinklabs.io>
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the CI pipeline for publishing releases by incorporating Windows-specific steps using windows-latest and PowerShell. Key changes include:
- Adding a global environment variable (APPLICATION_NAME) for consistent usage across steps.
- Introducing Windows-specific workflow steps for setting the release tag, building the binary, signing the binary, uploading release assets, and attesting the build.
- Modifying the matrix to include windows runners and using PowerShell (pwsh) commands for Windows tasks.
Comments suppressed due to low confidence (2)
.github/workflows/publish.yml:144
- Consider using a consistent variable naming convention between Windows and non-Windows steps (e.g., consistently use 'filename' instead of mixing '$filename' and '_filename') to improve code clarity.
$filename = "${{ env.APPLICATION_NAME }}.exe"
.github/workflows/publish.yml:148
- Ensure that the PowerShell line continuation character (`) is supported in your target PowerShell versions and behaves as expected; testing on the specific environments is recommended.
java -jar jsign.jar `
agaffney
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.