test(event): governance actions

[wolf31o2]

Summary by cubic

Add unit tests for governance action extraction to ensure correct parsing of treasury withdrawals, committee updates, new constitution anchors/script hash, Conway parameter changes (policy hash, execution units, rational values, governance params), and previous action IDs. Also add a test for rational-to-float conversion.

^{Written for commit b767b9a. Summary will update on new commits.}

Summary by CodeRabbit

• Tests
  • Expanded test coverage for governance data extraction with comprehensive test suites for treasury withdrawals, committee updates, constitution changes, and parameter modifications.
  • Added validation tests for policy and script hash handling, data transformations, and aggregation logic across multiple governance action scenarios.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request adds a comprehensive test suite to event/governance_test.go covering governance data extraction across multiple action types. The new tests validate the extractGovActionData function with TreasuryWithdrawal, UpdateCommittee, NewConstitution, and ParameterChange actions. Tests include scenarios for policy hashes, script/data hashes, PrevActionId handling, and Conway parameter changes covering fields like MinFeeA/B, MaxTxSize, and rational value conversions. The rationalToFloat helper function is also tested with edge cases. Total lines added: 327.

Possibly related PRs

• feat(event): governance action created #590: Introduces Conway parameter-change fields and data structures that the new tests directly validate through extractGovActionData and related extraction functions.

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'test(event): governance actions' accurately describes the main change, which is adding a comprehensive test suite for governance data extraction across multiple action types.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch test/governance

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 1 file