fix: guard against nil transaction

[wolf31o2]

Summary by cubic

Add a nil check in SubmitTx and return "transaction is required" when the request has no tx. This prevents crashes from nil dereferences on invalid client requests.

^{Written for commit 814856a. Summary will update automatically on new commits.}

Summary by CodeRabbit

• Bug Fixes
  • Enhanced transaction submission validation to properly reject missing or invalid transaction data with a clear error message, preventing potential processing errors.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

A nil-check was added to the SubmitTx function in internal/utxorpc/submit.go. When the transaction payload (txRaw) is nil, the function now returns early with an error message "transaction is required" instead of proceeding with execution. This implements input validation using a fail-fast pattern.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

• Single file modified with a straightforward guard clause
• No changes to function signatures or exported entities
• Defensive input validation with clear error messaging

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: guard against nil transaction' accurately and concisely describes the main change: adding a nil-check for transaction payloads in the SubmitTx function.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/guard-nil-tx

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 16888c8 and 814856a.

📒 Files selected for processing (1)

• internal/utxorpc/submit.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: cubic · AI code reviewer
• GitHub Check: Analyze (go)

🔇 Additional comments (1)

internal/utxorpc/submit.go (1)

45-48: Nil transaction guard correctly prevents nil dereference

Adding the early return when txRaw is nil cleanly avoids a potential panic at txRaw.GetRaw() and enforces a clear “transaction is required” contract for callers. The change is minimal, consistent with existing error handling, and introduces no new edge cases in SubmitTx.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 1 file