feat(dolos): bump dolos version and add kupo support#370
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)✅ Unit Test PR creation complete.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Note Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it. Generating unit tests... This may take up to 20 minutes. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@charts/dolos/templates/headless-service.yaml`:
- Around line 23-27: The ports block is gated only by .Values.ports.minikupo but
uses .Values.service.ports.minikupo for the port field, which can produce an
empty/invalid Service; update the gate to require both keys (e.g., change the
condition to check both .Values.ports.minikupo and
.Values.service.ports.minikupo) or add a Helm required(...) call for
.Values.service.ports.minikupo before rendering (so the template fails fast with
a clear message); target the conditional surrounding the minikupo block and the
references to .Values.service.ports.minikupo and .Values.ports.minikupo to
implement this change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 477b0f23-9661-469b-b085-8721839a2a2d
📒 Files selected for processing (4)
charts/dolos/Chart.yamlcharts/dolos/templates/headless-service.yamlcharts/dolos/templates/sts.yamlcharts/dolos/values.yaml
Signed-off-by: Ales Verbic <verbotenj@blinklabs.io>
cd3480c to
f4d4176
Compare
|
✅ Created PR with unit tests: #371 |
Summary by CodeRabbit
New Features
Chores
Summary by cubic
Bumps the
doloschart to 0.4.6/app to 1.0.3 and adds optional MiniKupo API support with a newminikupoport and config.New Features
minikupoport on the StatefulSet and headless Service; off by default and enabled when both.Values.ports.minikupoand.Values.service.ports.minikupoare set.ports.minikupo,service.ports.minikupo,configmap.http.minikupo(withlisten_addressandpermissive_cors), andconfigmap.api.include_minikupo.Dependencies
ghcr.io/txpipe/dolos:v1.0.3.version→ 0.4.6 andappVersion→ 1.0.3.Written for commit f4d4176. Summary will update on new commits.