Skip to content

feat(dolos): bump dolos version and add kupo support#370

Merged
verbotenj merged 1 commit intomainfrom
feat-dolos-minikupo-port
Apr 24, 2026
Merged

feat(dolos): bump dolos version and add kupo support#370
verbotenj merged 1 commit intomainfrom
feat-dolos-minikupo-port

Conversation

@verbotenj
Copy link
Copy Markdown
Contributor

@verbotenj verbotenj commented Apr 24, 2026

Summary by CodeRabbit

  • New Features

    • Added optional MiniKupo API configuration and support, including configurable ports and CORS settings.
  • Chores

    • Bumped Helm chart version to 0.4.6.
    • Updated application version to 1.0.3.
    • Updated container image to v1.0.3.

Summary by cubic

Bumps the dolos chart to 0.4.6/app to 1.0.3 and adds optional MiniKupo API support with a new minikupo port and config.

  • New Features

    • Optional minikupo port on the StatefulSet and headless Service; off by default and enabled when both .Values.ports.minikupo and .Values.service.ports.minikupo are set.
    • Example values for ports.minikupo, service.ports.minikupo, configmap.http.minikupo (with listen_address and permissive_cors), and configmap.api.include_minikupo.
  • Dependencies

    • Image updated to ghcr.io/txpipe/dolos:v1.0.3.
    • Chart version → 0.4.6 and appVersion → 1.0.3.

Written for commit f4d4176. Summary will update on new commits.

@verbotenj verbotenj requested review from a team as code owners April 24, 2026 00:47
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 477b0f23-9661-469b-b085-8721839a2a2d

📥 Commits

Reviewing files that changed from the base of the PR and between bf22377 and cd3480c.

📒 Files selected for processing (4)
  • charts/dolos/Chart.yaml
  • charts/dolos/templates/headless-service.yaml
  • charts/dolos/templates/sts.yaml
  • charts/dolos/values.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)

✅ Unit Test PR creation complete.

  • Create PR with unit tests
  • Commit unit tests in branch feat-dolos-minikupo-port

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026

Note

Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it.


Generating unit tests... This may take up to 20 minutes.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@charts/dolos/templates/headless-service.yaml`:
- Around line 23-27: The ports block is gated only by .Values.ports.minikupo but
uses .Values.service.ports.minikupo for the port field, which can produce an
empty/invalid Service; update the gate to require both keys (e.g., change the
condition to check both .Values.ports.minikupo and
.Values.service.ports.minikupo) or add a Helm required(...) call for
.Values.service.ports.minikupo before rendering (so the template fails fast with
a clear message); target the conditional surrounding the minikupo block and the
references to .Values.service.ports.minikupo and .Values.ports.minikupo to
implement this change.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 477b0f23-9661-469b-b085-8721839a2a2d

📥 Commits

Reviewing files that changed from the base of the PR and between bf22377 and cd3480c.

📒 Files selected for processing (4)
  • charts/dolos/Chart.yaml
  • charts/dolos/templates/headless-service.yaml
  • charts/dolos/templates/sts.yaml
  • charts/dolos/values.yaml

Comment thread charts/dolos/templates/headless-service.yaml Outdated
Signed-off-by: Ales Verbic <verbotenj@blinklabs.io>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026

✅ Created PR with unit tests: #371

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@verbotenj verbotenj merged commit 91194f8 into main Apr 24, 2026
7 checks passed
@verbotenj verbotenj deleted the feat-dolos-minikupo-port branch April 24, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants