update bitcoin to 0.18.1 #1
Open
+730,461
−230,164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72a5aa9 depends: don't install & then delete sqlite pkgconf (fanquake) Pull request description: ACKs for top commit: stickies-v: ACK 72a5aa9 hebasto: ACK 72a5aa9. Tree-SHA512: d70b024ca68294ab79e5f9aa15ab8a17eca83f65713d5de3b421e868b0f24c26a459a6240d348438fd4706a9f46e96ab4979e952099d5f2a9bc00e8e1a7b558f
One of the benefits of using a compilation database, which is available after the CMake build system generation step, is that it is not necessary to actually build the code in order to run `clang-tidy`.
4b1b36a doc: Remove build instruction for running `clang-tidy` (Hennadii Stepanov) Pull request description: One of the benefits of using a compilation database, which is available after the CMake build system generation step, is that it is not necessary to actually build the code in order to run `clang-tidy`. ACKs for top commit: TheCharlatan: ACK 4b1b36a janb84: ACK 4b1b36a Tree-SHA512: cf28fb1bcff83016b927522f1c719f3b91df7d107a310250c550308c8544b212fa6d2e8a5502d69fa424421acdf952469edd67504ac2a8465a2c1520593a1f26
getaddressinfo, listunspent, listtransactions, listsinceblock, and gettransaction all include parent_desc(s). Make sure that these are consistent with each other, as well as being in normalized form.
86e1111 test: verify node skips loading legacy wallets during startup (furszy) 9f94de5 wallet: init, don't error out when loading legacy wallets (furszy) Pull request description: Instead of failing during initialization and shutting down the app when encountering a legacy wallet, skip loading the wallet and notify the user accordingly. This allows users to access migration functionalities without needing to manually remove the wallet from settings.json or resort to using the bitcoin-wallet utility. This means that GUI users will be able to use the migration button, and bitcoin-cli users will be able to call the migratewallet RPC directly after init. ACKs for top commit: achow101: ACK 86e1111 w0xlt: ACK 86e1111 Tree-SHA512: 85d594a503ee7a833a23754b71b6ba4869ca34ed802c9ac0cd7b2fa56978f5fcad84ee4bd3acdcc61cf8e7f08f0789336febc5d76beae1eebf7bd51462512b78
6ee32aa test: signet tool genpsbt and solvepsbt commands (Sjors Provoost) 0a99d99 signet: miner skips PSBT step for OP_TRUE (Sjors Provoost) cdfb70e signet: split decode_psbt miner helper (Sjors Provoost) Pull request description: [BIP325](https://github.com/bitcoin/bips/blob/master/bip-0325.mediawiki) mentions the following rule: > In the special case where an empty solution is valid (ie scriptSig and scriptWitness are both empty) this additional commitment can optionally be left out. This special case is to allow non-signet-aware block generation code to be used to test a custom signet chain where the challenge is trivially true. Such a signet can be created using e.g. `-signetchallenge=51` (`OP_TRUE`). However `contrib/signet/miner` won't omit the commitment. This PR improves the miner by skipping the PSBT for known trivial scripts (just `OP_TRUE` and trivial pushes for now). This prevents it from appending the 4 byte signet header to the witness commitment, as allowed by the above rule. --- Previously the script would fail with `PSBT signing failed`, making it difficult to mine. This is no longer the case. ACKs for top commit: achow101: ACK 6ee32aa theStack: re-ACK 6ee32aa danielabrozzoni: ACK 6ee32aa Tree-SHA512: e47fbf471f2909286a6c1c073799ea388b9c19551afcce96cf9af45cc48d25c02f1e48e08861a88b604361e2c107a759d5baf393da8a37360de419f31651758a
Some are now redirecting, some are outdated, i.e qt5.
Co-authored-by: Ragnar <[email protected]> Co-authored-by: VolodymyrBg <[email protected]>
e50312e doc: fix typos (fanquake) c797e50 ci: update codespell to 2.4.1 (fanquake) 21ee656 doc: Remove obselete link in notificator.cpp (strmfos) ee4406c doc: update URLs (fanquake) Pull request description: A round up of #32629 + some other changes that had previously been PR'd. ACKs for top commit: maflcko: review ACK e50312e 🥗 Tree-SHA512: 8fa3e14fdfa0cf65a42debc9cbb1f8b379aba44aa185e2e27337431e884d169bf1e811655c3a884d918e65ea28c5767ddaabaf25c862ebd9b4b38a0229ec5a93
This can be reproduced according to the developer notes with something like ( cd ./src/ && ../contrib/devtools/run-clang-tidy.py -p ../bld-cmake -fix -j $(nproc) ) Also, the header related changes were done manually.
Historically, the headers have been bumped some time after a file has been touched. Do it now to avoid having to touch them again in the future for that reason. -BEGIN VERIFY SCRIPT- sed -i --regexp-extended 's;( 20[0-2][0-9])(-20[0-2][0-9])? The Bitcoin Core developers;\1-present The Bitcoin Core developers;g' $( git show --pretty="" --name-only HEAD~0 ) -END VERIFY SCRIPT-
This makes it easier to compare test and bitcoind logs - combine_logs.py orders by timestamp and will be more precise.
df9ebbf depends: use "mkdir -p" when installing xproto (fanquake) Pull request description: It looks like the mkdir detection in xproto is broken on Alpine. Ensure we always use `mkdir -p`. Fixes #32494. ACKs for top commit: hebasto: ACK df9ebbf, I have reviewed the code and it looks OK. janb84: ACK df9ebbf willcl-ark: ACK df9ebbf Tree-SHA512: 0f23b1096ffdf5ffa13115665dc42b65835b78bb0ab04a8be8f210980356953ab518e1273302fe4c9239361201f4f9ac737c0ebf10625f4817f81b65b3b25572
83bfe14 build: add -Wthread-safety-pointer (fanquake) 240a4fb Squashed 'src/leveldb/' changes from 113db4962b..aba469ad6a (fanquake) Pull request description: This will become available in Clang 21: > ThreadSafetyAnalysis now supports -Wthread-safety-pointer, which > enables warning on passing or returning pointers to guarded variables > as function arguments or return value respectively. Note that > ThreadSafetyAnalysis still does not perform alias analysis. The > feature will be default-enabled with -Wthread-safety in a future release. See https://github.com/llvm/llvm-project/blob/main/clang/docs/ReleaseNotes.rst. Also updates the leveldb subtree to pull: bitcoin-core/leveldb-subtree#54. ACKs for top commit: davidgumberg: Tested ACK 83bfe14 maflcko: lgtm ACK 83bfe14 theuni: utACK 83bfe14 Tree-SHA512: 9bc80bd04a9cebed8aca20bc23a17e52a6a89a1fb042993322f43dbf7bd93de509c091ebb69255063833b098ab11a64285eccf61e17b9f94f974c734a20ad8da
Current behaviour will by-default use SOURCE_DATE_EPOCH from the environment without warning. This breaks the default reproducibility from a guix build. Warn when and exit when this variable is set, and FORCE_SOURCE_DATE_EPOCH is unset.
…t6_add_lrelease` 18cf727 cmake: Replace deprecated `qt6_add_translation` with `qt6_add_lrelease` (Hennadii Stepanov) Pull request description: See Qt docs: - https://doc.qt.io/archives/qt-6.2/qtlinguist-cmake-qt-add-translation.html - https://doc.qt.io/archives/qt-6.2/qtlinguist-cmake-qt-add-lrelease.html ACKs for top commit: fanquake: ACK 18cf727 Tree-SHA512: 10a4023b24d2936a41b8049063b0e210b76cd4d9c9e22a28de579a211f047b5446785005d6918f0b80c6461960717be62cf9b92b0c66000a95379a41dfa83fd2
…ckage f98e1aa rpc: Note in fundrawtransaction doc, fee rate is for package (benthecarman) Pull request description: Accidentally made some transactions with a much higher fee rate than I wanted because I did not know this would do it for the package rather than the individual tx. ACKs for top commit: achow101: ACK f98e1aa rkrux: re-ACK f98e1aa danielabrozzoni: ACK f98e1aa Tree-SHA512: 9f961de1200803ec4d1c6901fd606bb6cf707ffd03942d9dc0d4b6554c827075f99d693b93e892f728679d67e63e12c71da4426dab091b3311d1605bc37251a2
…ging ed179e0 test: apply microsecond precision to test framework logging (Martin Zumsande) Pull request description: When analyzing functional test logs (produced with `combine_logs.py`), entries sometimes sort slightly out of order because even though python prints 6 digits for microsecond precision, it fills up the last 3 digits with zeroes. For example, it may look like a message was received by the test framework before it was sent by the node. Change this to actually use microsecond precision - this should make combined logs a little bit easier to analyze. ACKs for top commit: davidgumberg: Tested ACK ed179e0 achow101: ACK ed179e0 maflcko: review ACK ed179e0 🗳 janb84: ACK ed179e0 Tree-SHA512: 55cdb5024e8e910c5a5ce741ce512eb88f4f82f11f378ba0fe7a5a2b1c97d2e7b540bdf5603c76aab837d35798610b165f087fbeb7c9dc90aaad890bf4d0323d
Since isEncrypted opens a file to search for a particular record, it needs to use BERKELEY_RO when opening a legacy wallet.
cfc42ae fuzz: add a target for the coins database (Antoine Poinsot) 46e1463 fuzz: move the coins_view target's body into a standalone function (Antoine Poinsot) 56d878c fuzz: avoid underflow in coins_view target (Antoine Poinsot) Pull request description: This reopens #28216. The current `coins_view` target only tests `CCoinsViewCache` using a basic `CCoinsView` instance. The addition of the `coins_view_db` target enables testing with an actual `CCoinsViewDB` as the backend. ACKs for top commit: maflcko: lgtm ACK cfc42ae l0rinc: code review ACK cfc42ae TheCharlatan: ACK cfc42ae Tree-SHA512: d3a92f122629f075767453a1abd9819a1c9716db53b997418993fef62d27683324740d0a8f84df76d8a7a45e508ccadeb69553b6f69e29a1238cd7c0be5276ca
Following #32540 (comment). -BEGIN VERIFY SCRIPT- sed -i 's/\<strURIPart\>/uri_part/g' src/rest.cpp -END VERIFY SCRIPT-
The `boost-headers` package does not provide CMake configuration files required since #32667. Install the `boost` package instead.
Due to a bug in `boost_headers-config.cmake`, the `Boost::headers` target's `INTERFACE_INCLUDE_DIRECTORIES` property is set to "/usr", which is incorrect.
856f423 scripted-diff: rest: rename `strURIPart` -> `uri_part` (Roman Zeyde) Pull request description: Following #32540 (comment). ACKs for top commit: l0rinc: reACK 856f423 maflcko: lgtm ACK 856f423 Tree-SHA512: a56a66872e632eed65fe1f75b9873dcf1d713cf09eba6e1e4031c58d88a5427a5bb7e49be4951ba22dfe4c9b558bb86f0f071fa42fc9cb50689564fe0b3b0297
7dc43ea test: Add msgtype to msg_generic slots (dergoegge) Pull request description: `msg_generic` can't be used unless `msgtype` is listed in `__slots__` Example from a [custom test](https://github.com/dergoegge/bitcoin/blob/6329ce979f63b396aa036a1ad39798bb83fa4ade/test/functional/p2p_bug28676.py): ``` 2025-06-30T10:14:55.418000Z TestFramework (INFO): PRNG seed is: 3137163719543762151 2025-06-30T10:14:55.418000Z TestFramework (INFO): Initializing test directory /tmp/nix-shell-110135-0/bitcoin_func_test_7lmiemmp 2025-06-30T10:14:55.675000Z TestFramework (INFO): Setting up connections & mining some blocks... 2025-06-30T10:14:56.511000Z TestFramework (ERROR): Unexpected exception caught during testing Traceback (most recent call last): File "/home/dergoegge/workspace/bitcoin/worktrees/master/test/functional/test_framework/test_framework.py", line 189, in main self.run_test() File "/home/dergoegge/workspace/bitcoin/worktrees/master/./build/test/functional/p2p_bug28676.py", line 46, in run_test self.connections[0].send_without_ping(msg_generic(b"block", bytes.fromhex("0500000006226e46111a0b59caaf126043eb5bbf28c34f3a5e332a1fc7b2b73cf188910f06b816712ffab8c59299a6abb58ccefa1995a1368ca4348782ef268cbc9bacacdbe5494dffff7f200200000001010000000001010000000000000000000000000000000000000000000000000000000000000000ffffffff075105ffffffff00ffffffff0200f90295000000002200204ae81572f06e1b88fd5ced7a1a000945432e83e1551e6f721ee9c00b8cc332600000000000000000266a24aa21a9ede2f61c3f71d1defd3fa999dfa36953755c690689799962b48bebd836974e8cf90120000000000000000000000000000000000000000000000000000000000000000000000000"))) File "/home/dergoegge/workspace/bitcoin/worktrees/master/test/functional/test_framework/messages.py", line 1386, in __init__ self.msgtype = msgtype AttributeError: 'msg_generic' object has no attribute 'msgtype' ``` ACKs for top commit: maflcko: lgtm ACK 7dc43ea theStack: ACK 7dc43ea Tree-SHA512: 8c634d50a884b063117e8ae29510ffd013e73dda9f8b0f73d098e80038b610ef8d80bd2e576c37f0cedfb4b6baa3d4ebeceb0902f29f90d59e1525f418f712fe
fa3f100 test: Use msg_generic in p2p_ping.py (MarcoFalke) Pull request description: It seems odd to derive `msg_pong_corrupt` from `msg_pong`, but then overwrite the serialize method, when one can just directly use `msg_generic` to pass the raw bytes to send over the wire. Fix that by using `msg_generic`. This also serves as a regression test against the fix in commit 3348057. (Can be tested by reverting that commit to observe a failure) ACKs for top commit: dergoegge: utACK fa3f100 theStack: ACK fa3f100 Tree-SHA512: 53d7d2289f27646fdf7d3b86c53e8e707fa4ca4b006d232850f9dc27409d79b7abe1dece95ccef429d4b52c6a89579c0cc5c0ee37046375c3c0310a2d6f9ddd5
28299ce p2p: remove vestigial READ_STATUS_CHECKBLOCK_FAILED (Greg Sanders) bac9ee4 p2p: Add witness mutation check inside FillBlock (Greg Sanders) Pull request description: Since #29412, we have not allowed mutated blocks to continue being processed immediately the block is received, but this is only done for the legacy BLOCK message. Extend these checks as belt-and-suspenders to not allow similar mutation strategies to affect relay by honest peers by applying the check inside `PartiallyDownloadedBlock::FillBlock`, immediately before returning `READ_STATUS_OK`. ACKs for top commit: Crypt-iQ: ACK 28299ce achow101: ACK 28299ce stratospher: ACK 28299ce. dergoegge: Code review ACK 28299ce Tree-SHA512: 883d7c12ca096234b425e6fe12e46b0611607600916e6ac8d1c8112224aa76924b7b074754910163ac2ec15379075d618a9ece3642649ac7629cddb0d4e432ea
6967e8e add more bad p2p ports (Jameson Lopp) Pull request description: Add a few more ports used by extremely well adopted services that require authentication and really ought not be used by bitcoin nodes for p2p traffic. ACKs for top commit: Sjors: utACK 6967e8e l0rinc: ACK 6967e8e glozow: ACK 6967e8e Tree-SHA512: bbe86aef2be9727338712ded8f90227f5d12f633ab5d324c8907c01173945d1c4d9899e05565f78688842bbf5ebb010d22173969e4168ea08d4e33f01fe9569d
fa21631 test: Use self.log (MarcoFalke) fa346f7 test: Move error string into exception (MarcoFalke) fa19861 test: Remove useless catch-throw (MarcoFalke) fa2f1c5 move-only util data to test/functional/data/util (MarcoFalke) faa18bf test: Turn util/test_runner into functional test (MarcoFalke) fa95515 test: Add missing skip_if_no_bitcoin_tx (MarcoFalke) fac9db6 test: Add missing tx util to Binaries (MarcoFalke) fa91835 test: Use lowercase env var as attribute name (MarcoFalke) fac4909 test: Remove duplicate ConfigParser (MarcoFalke) Pull request description: The `test/util/test_runner.py` has many issues: * The boilerplate for the test runner is duplicate or inconsistent with the other (functional) tests. For example, logging options, `ConfigParser` handling, `Binaries` handling ... * The cmake/ci behavior is brittle and can silently fail, as explained in #31476 * corecheck (and likely other places that manually run the tests) completely forget to run it * If the test is manually called, it runs single threaded, when it could just run in parallel with the other functional tests Fix all issues by removing the util test_runner and moving the test logic into a new functional test file. ACKs for top commit: janb84: re ACK fa21631 brunoerg: re-ACK fa21631 hebasto: re-ACK fa21631, additional feedback has been addressed since my previous [review](#32697 (review)). Tree-SHA512: 694e647887801f002843a74011035d5ed3dfed091d3f0ae18e812a16a4680e04e60e50de0a92af7e047e8ddd6ff5a7834c690f16fd42b74ebc1674bf9989406f
Currently if the version 3 is selected for an otherwise standard spender, the test will fail. It's unlikely but possible, so change the test to update expectations and sample more aggressively on border values to instigate failures much quicker in the future if another version is made standard.
…ity.md 45b1d39 doc: Add fetching single PRs from upstream (will) Pull request description: Current recommendation is to add a new remote fetching all PRs, but this is resource-intensive. Document a better way to fetch a single PR, and to update a PR which has been force-pushed. Follows up on a [comment from 32774](#32774 (comment)) ACKs for top commit: pablomartin4btc: re-ACK 45b1d39 achow101: ACK 45b1d39 janb84: re ACK 45b1d39 theStack: ACK 45b1d39 Tree-SHA512: 3af02aa1335fd941538fabaa527bcfa92907dc6c272e72bc37ca38211b8aeebf32dd1837f976308058360ed1364fec749b49213f2b8bc4e35542da55a7bd30e1
dd99ced doc: add `/spenttxouts` to REST-interface.md (Sebastian Falbesoner) Pull request description: Seems like adding the `spenttxouts` endpoint to the REST interface description was forgotten in #32540. ACKs for top commit: maflcko: lgtm ACK dd99ced pablomartin4btc: ACK dd99ced Tree-SHA512: 9b1da9cbab914664217cc7f8792092e672518ec7f79c7670eb1c54ef94e6cd52b139e1051035ce33ad62b7b74a169e3abc793d1804760787a11a0dc269d26402
6bb38bf Update p2p_monitor.py (leopardracer) Pull request description: Fix typo in variable name in p2p_monitor.py. ACKs for top commit: maflcko: lgtm ACK 6bb38bf Tree-SHA512: 3d18b56766acd35f86e002fda7460f57ef8d09dd8948cc5aa172f720789624f52e1a2e4f7b095fcee7e524bdc63228903056ab2339d206efd5fbbb4189eeb969
Also, capitalized the comments in build-unix.md for uniformity with the docs on other targets.
…uts in memory 215e599 wallet: Remove unused CachedTxGet{Available,Immature}Credit (Ava Chow) 49675de wallet: Have GetDebit use the wallet's TXO set (Ava Chow) 17d453c wallet: Recompute wallet TXOs after descriptor migration (Ava Chow) 764016e wallet: Retrieve TXO directly in FetchSelectedInputs (Ava Chow) c1801b7 wallet: Use wallet's TXO set in AvailableCoins (Ava Chow) dde7cbe wallet: Change balance calculation to use m_txos (Ava Chow) 96e7a89 wallet: Recalculate the wallet's txos after any imports (Ava Chow) ae888c3 wallet: Exit IsTrustedTx early if wtx is already in trusted_parents (Ava Chow) ae0876e wallet: Keep track of transaction outputs owned by the wallet (Ava Chow) 0f269bc walletdb: Load Txs last (Ava Chow) 5cc32ee test: Test for balance update due to untracked output becoming spendable (Ava Chow) 8222341 wallet: MarkDirty after AddWalletDescriptor (Ava Chow) e02f2d3 bench: Have AvailableCoins benchmark include a lot of unrelated utxos (Ava Chow) Pull request description: Currently, the wallet is not actually aware about its own transaction outputs. Instead, it will iterate all of the transactions stored in `mapWallet`, and then all of the outputs of those transactions, in order to figure out what belongs to it for the purposes of coin selection and balance calculation. For balance calculation, there is caching that results in it only iterating all of the transactions, but not all of the outputs. However when the cache is dirty, everything is iterated. This is especially problematic for wallets that have a lot of transactions, or transactions that have a lot of unrelated outputs (as may occur with coinjoins or batched payments). This PR helps to resolve this issue by making the wallet track all of the outputs that belong to it in a new member `m_txos`. Note that this includes outputs that may have already been spent. Both balance calculation (`GetBalance`) and coin selection (`AvailableCoins`) are updated to iterate `m_txos`. This is generally faster since it ignores all of the unrelated outputs, and it is not slower as in the worst case of wallets containing only single output transactions, it's exactly the same number of outputs iterated. `m_txos` is memory only, and it is populated during wallet loading. When each transaction is loaded, all of its outputs are checked to see if it is `IsMine`, and if so, an entry added to `m_txos`. When new transactions are received, the same procedure is done. Since imports can change the `IsMine` status of a transaction (although they can only be "promoted" from watchonly to spendable), all of the import RPCs will be a bit slower as they re-iterate all transactions and all outputs to update `m_txos`. Each output in `m_txos` is stored in a new `WalletTXO` class. This class contains references to the parent `CWalletTx` and the `CTxOut` itself. It also caches the `IsMine` value of the txout. This should be safe as `IsMine` should not change unless there are imports. This allows us to have additional performance improvements in places that use these `WalletTXO`s as they can use the cached `IsMine` rather than repeatedly calling `IsMine` which can be expensive. The existing `WalletBalance` benchmark demonstrates the performance improvement that this PR makes. The existing `WalletAvailableCoins` benchmark doesn't as all of the outputs used in that benchmark belong to the test wallet. I've updated that benchmark to have a bunch of unrelated outputs in each transaction so that the difference is demonstrated. This is part of a larger project to have the wallet actually track and store a set of its UTXOs. Built on #24914 as it requires loading the txs last in order for `m_txos` to be built correctly. *** ## Benchmarks: Master: | ns/op | op/s | err% | ins/op | cyc/op | IPC | bra/op | miss% | total | benchmark |--------------------:|--------------------:|--------:|----------------:|----------------:|-------:|---------------:|--------:|----------:|:---------- | 34,590,013.00 | 28.91 | 0.0% | 812,669,269.00 | 148,360,642.50 | 5.478 | 18,356,853.00 | 0.2% | 0.76 | `WalletAvailableCoins` | 3,193.46 | 313,139.91 | 0.4% | 96,868.06 | 13,731.82 | 7.054 | 26,238.01 | 0.1% | 0.01 | `WalletBalanceClean` | 26,871.18 | 37,214.59 | 3.3% | 768,179.50 | 115,544.39 | 6.648 | 154,171.09 | 0.1% | 0.01 | `WalletBalanceDirty` | 3,177.30 | 314,732.47 | 0.2% | 96,868.06 | 13,646.20 | 7.099 | 26,238.01 | 0.1% | 0.01 | `WalletBalanceMine` | 10.73 | 93,186,952.53 | 0.1% | 157.00 | 46.14 | 3.403 | 36.00 | 0.0% | 0.01 | `WalletBalanceWatch` | 590,497,920.00 | 1.69 | 0.1% |12,761,692,005.00 |2,536,899,595.00 | 5.030 | 129,124,399.00 | 0.7% | 6.50 | `WalletCreateEncrypted` | 182,929,529.00 | 5.47 | 0.0% |4,199,271,397.00 | 785,477,302.00 | 5.346 | 75,363,377.00 | 1.1% | 2.01 | `WalletCreatePlain` | 699,337.20 | 1,429.93 | 0.7% | 18,054,294.00 | 3,005,072.20 | 6.008 | 387,756.60 | 0.3% | 0.04 | `WalletCreateTxUseOnlyPresetInputs` | 32,068,583.80 | 31.18 | 0.5% | 562,026,110.00 | 137,457,635.60 | 4.089 | 90,667,459.40 | 0.3% | 1.78 | `WalletCreateTxUsePresetInputsAndCoinSelection` | 36.62 | 27,306,578.40 | 0.5% | 951.00 | 157.05 | 6.056 | 133.00 | 0.0% | 0.01 | `WalletIsMineDescriptors` | 35.00 | 28,569,989.42 | 0.7% | 937.00 | 150.33 | 6.233 | 129.00 | 0.0% | 0.01 | `WalletIsMineMigratedDescriptors` | 203,284,889.00 | 4.92 | 0.0% |4,622,691,895.00 | 872,875,275.00 | 5.296 | 90,345,002.00 | 1.2% | 1.02 | `WalletLoadingDescriptors` | 1,165,766,084.00 | 0.86 | 0.0% |24,139,316,211.00 |5,005,218,705.00 | 4.823 |2,664,455,775.00 | 0.1% | 1.17 | `WalletMigration` PR: | ns/op | op/s | err% | ins/op | cyc/op | IPC | bra/op | miss% | total | benchmark |--------------------:|--------------------:|--------:|----------------:|----------------:|-------:|---------------:|--------:|----------:|:---------- | 33,975,750.50 | 29.43 | 0.1% | 794,719,150.50 | 145,763,550.00 | 5.452 | 16,036,630.50 | 0.2% | 0.75 | `WalletAvailableCoins` | 2,442.01 | 409,498.46 | 0.2% | 60,782.04 | 10,500.60 | 5.788 | 9,492.01 | 0.3% | 0.01 | `WalletBalanceClean` | 2,763.12 | 361,909.21 | 0.2% | 61,493.05 | 11,859.48 | 5.185 | 9,625.01 | 0.2% | 0.01 | `WalletBalanceDirty` | 2,347.98 | 425,898.72 | 0.3% | 60,782.04 | 10,082.73 | 6.028 | 9,492.01 | 0.2% | 0.01 | `WalletBalanceMine` | 11.67 | 85,654,630.36 | 0.2% | 176.00 | 50.18 | 3.508 | 40.00 | 0.0% | 0.01 | `WalletBalanceWatch` | 590,119,519.00 | 1.69 | 0.1% |12,754,398,258.00 |2,534,998,522.00 | 5.031 | 129,078,027.00 | 0.7% | 6.50 | `WalletCreateEncrypted` | 183,124,790.00 | 5.46 | 0.1% |4,199,212,926.00 | 786,323,886.00 | 5.340 | 75,354,437.00 | 1.1% | 2.02 | `WalletCreatePlain` | 669,643.00 | 1,493.33 | 0.1% | 17,213,904.20 | 2,877,336.40 | 5.983 | 394,292.80 | 0.3% | 0.04 | `WalletCreateTxUseOnlyPresetInputs` | 26,205,987.80 | 38.16 | 0.8% | 365,551,340.80 | 112,376,905.20 | 3.253 | 65,684,276.20 | 0.4% | 1.44 | `WalletCreateTxUsePresetInputsAndCoinSelection` | 34.75 | 28,778,846.38 | 0.1% | 937.00 | 149.41 | 6.271 | 129.00 | 0.0% | 0.01 | `WalletIsMineDescriptors` | 29.91 | 33,428,072.85 | 0.2% | 920.00 | 128.63 | 7.152 | 126.00 | 0.0% | 0.01 | `WalletIsMineMigratedDescriptors` | 202,437,985.00 | 4.94 | 0.1% |4,626,686,256.00 | 869,439,274.00 | 5.321 | 90,961,305.00 | 1.1% | 1.02 | `WalletLoadingDescriptors` | 1,158,394,152.00 | 0.86 | 0.0% |24,143,589,972.00 |4,971,946,380.00 | 4.856 |2,665,355,654.00 | 0.1% | 1.16 | `WalletMigration` ACKs for top commit: davidgumberg: untested reACK 215e599 murchandamus: reACK 215e599 ishaanam: reACK 215e599 w0xlt: reACK 215e599 Tree-SHA512: d6b929de56f67930678db654e46f15fb71008390189c701a026b2d76af8f14a7c9769e49835ce7e2b6515d2934a77aad8de0b1a82231a2e1de5337de25db9629
…ild" part 0e9f409 doc: clarify that the "-j N" goes after the "--build build" part (Salvatore Ingala) Pull request description: I was surprised that something like `cmake -j 4 --build build` doesn't work, so this might help others to not make the same mistake. ACKs for top commit: achow101: ACK 0e9f409 hebasto: ACK 0e9f409. stickies-v: ACK 0e9f409 pablomartin4btc: ACK 0e9f409 theStack: ACK 0e9f409 brunoerg: ACK 0e9f409 w0xlt: ACK 0e9f409 Tree-SHA512: 5283f87a68abae4905b773e73aa4529f52d2302d804165b560b22f300a449d8ce1ae3194d2e1fe69be6f7e4d279dd32b8ef0daa18af4ac6a76a51f5abc39ec63
…types instead of hardcoding them 8cc9845 wallet, rpc: Use `OUTPUT_TYPES` to describe the output types instead of hardcoding them (w0xlt) Pull request description: Follow-up to #32429, built on top of it. This PR addresses the #32429 (comment) that the RPC documentation does not use `OUTPUT_TYPES`, but rather hardcodes them, as is already the case for the `getnewaddress` command. So here the output types are changed from `std::string` to `std::string_view` so that the values are known at compile time or during the early stages of program startup, before main() execution. It also updates `wallet/rpc/addresses.cpp` to write the RPC docs according to `OUTPUT_TYPES` instead of using hardcoded version. It also updates the documentation in outputtypes.h, adding Doxygen comments, ACKs for top commit: maflcko: lgtm ACK 8cc9845 achow101: ACK 8cc9845 Tree-SHA512: e86d813d6d158dd2f6c62519a7ecaa878f2e4f686b5bae82028a106bd6671a13b10fb366f9bb7b94974777217e1852f38e8aa05bba00cd27f94f4412167a3562
941b8f5 ci: run get_previous_releases as part of test cross win job (Max Edwards) 5e21821 test: increment mocked time for migrating wallet backups (Max Edwards) 5174565 ci: disable feature_unsupported_utxo_db functional test (Max Edwards) 3dc90d6 test: remove mempool.dat before copying (Max Edwards) 67a6b20 test: add windows support to get previous releases script (Max Edwards) 1a1b478 scripted-diff: rename tarball to archive (Max Edwards) 4f06dc8 test: remove building from source from get prev releases script (Max Edwards) Pull request description: This PR updates the `test/get_previous_releases.py` script to also work on Windows by changing to be pure python rather than using unix tools such as `curl` and `tar`. This enables additional functional tests to run such as `wallet_migration.py`, `mempool_compatability.py` and `wallet_backwards_compatibility.py`. Unfortunately `feature_unsupported_utxo_db.py` _could_ run but this test requires Bitcoin `v0.14.3` which will not run under windows with emojis in the data directory (as the functional test runner has by default) . This test could be run as it's own step in the ci workflow file and would pass but as it's quite an old version / feature I have assumed it's not worth worrying about and best just to exclude. Two tests needed to be slightly modified to run under windows. Both were issues with trying to overwrite a file that already exists which windows seems to be more strict on than the unix based systems. Finally, building from source has been dropped from the `get_previous_releases.py` script. This had not been updated after the move to cmake and so it was assumed that nobody could have been using that feature. ACKs for top commit: maflcko: re-ACK 941b8f5 🍪 achow101: ACK 941b8f5 hodlinator: re-ACK 941b8f5 Tree-SHA512: 22933d0ec278b9b0ffcd2a8e90026e1a3631b00186e7f78bd65be925049021e319367d488c36a82ab526a07b264bac18c2777f87ca1174b231ed49fed56d11cb
…ness data 6efbd1e refactor: CTransaction equality should consider witness data (Cory Fields) cbf9b2d mempool: codify existing assumption about duplicate txids during removal (Cory Fields) e9331cd wallet: IsEquivalentTo should strip witness data in addition to scriptsigs (Cory Fields) Pull request description: I stumbled upon the `CTransaction` comparison operators while refactoring some nearby code. I found it surprising and not at all obvious that two transactions would test equal even if their witness data differed. It seems like an unnecessary potential footgun. Fix that by comparing against wtxid rather than txid. Outside of tests, there were only 3 users of these functions in the code-base: - Its use in the mempool has been replaced with an explicit txid comparison, as that's a tighter constraint and matches the old behavior. glozow suggested also upgrading this to an `Assume()`. - Its use in the wallet was accidentally doing the correct thing by ignoring witness data. I've changed that to an explicit witness removal so that `IsEquivalentTo` continues to work as-intended. - Its use in `getrawtransaction` is indifferent to the change. ACKs for top commit: maflcko: review ACK 6efbd1e 🦋 achow101: ACK 6efbd1e glozow: ACK 6efbd1e Tree-SHA512: 89be424889f49e7e26dd2bdab7fbc8b2def59bf002ae8b94989b349ce97245f007d6c96e409a626cbf0de9df83ae2485b4815b40a70f7aa5b6c720eb34a6c017
4be81e9 feature_taproot: sample tx version border values more (Greg Sanders) Pull request description: Currently if the version 3 is selected for an otherwise standard spender, the test will fail. It's unlikely but possible, so change the test to update expectations and sample more aggressively on border values to instigate failures much quicker in the future if another version is made standard. ACKs for top commit: maflcko: lgtm ACK 4be81e9 darosior: ACK 4be81e9 Tree-SHA512: 53267a201aaa495bea9d624930a19e40af3633427b6715965f43b9e1a060b2c9f19c8b10c8168778349fa50715e44cb8e5e9d2ce477d5f324ca8ed28ff7996cd
5a5ddbd build: Add workaround for NetBSD bug in `Boost::headers` target (Hennadii Stepanov) 4eb3cee doc: Update NetBSD Build Guide (Hennadii Stepanov) Pull request description: The recently merged #32667 broke builds on NetBSD due to the following issues: 1. The `boost-headers` package does not provide CMake configuration files now required since #32667. The first commit updates the Build Guide to recommend using the `boost` package instead. 2. The CMake configuration file provided by the `boost` package is [broken](NetBSD/pkgsrc#167). The second commit adds a workaround for this issue. Upstream issues: - NetBSD/pkgsrc#167 - NetBSD/pkgsrc#168 Successful CI job: https://github.com/hebasto/bitcoin-core-nightly/actions/runs/15958818914/job/45008576879. ACKs for top commit: purpleKarrot: ACK 5a5ddbd Tree-SHA512: 617543edf2216c3673195cc562541d7637d7ea199320916c3660a91f6ee1ff01c014f519c5eeb3fc224f7a7304fdb75965ee3f4554d7fb277dd05ba3a6583b45
… (re-take) a34fb9a miniscript: Make `operator""_mst` `consteval` (Pieter Wuille) 1405216 Revert "miniscript: make operator_mst consteval" (Hennadii Stepanov) Pull request description: Same as #28657, but without the refactoring required to work around [fixed](#28657 (comment)) MSVC bugs. The second commit has been taken from #29167. ACKs for top commit: sipa: ACK a34fb9a hodlinator: re-ACK a34fb9a Tree-SHA512: 8b531f9d6c450a8a5218865da05ffb5093d09ce2c0bee9874c0160795c4b1713928730d894ea3cd0b12b133346971ae3a00ed2fe8d9fd8a50b67a74ef81fde98
… a watch-only legacy wallet b789907 wallet: migration, avoid creating spendable wallet from a watch-only legacy wallet (furszy) e86d71b wallet: refactor, dedup wallet re-loading code (furszy) 1de423e wallet: introduce method to return all db created files (furszy) d04f6a9 refactor: remove sqlite dir path back-and-forth conversion (furszy) Pull request description: Currently, the migration process creates a brand-new descriptor wallet with no connection to the user's legacy wallet when the legacy wallet lacks key material and contains only watch-only scripts. This behavior is not aligned with user expectations. If the legacy wallet contains only watch-only scripts, the migration process should only generate a watch-only wallet instead. TODO List: * Explain that `migratewallet` renames the watch-only after migration, and also that the wallet will not have keys enabled. ACKs for top commit: achow101: ACK b789907 pablomartin4btc: tACK b789907 rkrux: LGTM ACK b789907 Tree-SHA512: 1d583ac4b206fb477e9727daf4b5ad9c3e18b12d40e1ab4a61e8565da44c3d0327c892b51cf47b4894405d122e414cefb6b6366c357e02a74a7ca96e06762d83
…viction_blocks_relay_only() ec004cd test: Use rehash() in outbound eviction block-relay (pablomartin4btc) 26598ed test: Clarify roles in outbound eviction comments (pablomartin4btc) Pull request description: This change avoids relying on `tip_header.hash`, which is `None` when the header is deserialized from hex during `CBlockHeader()` construction. Instead, `tip_header.rehash()` explicitly computes the hash, making the test behavior more robust. Using the explicit `rehash()` avoids depending on `wait_for_getheaders()` falling back to any received message, thus making the test more deterministic. This is a follow-up to #32742. Also, as noted in a previous review [comment](#32742 (review)), "_the hash field is wrong either way, simply due to being the wrong type (it is an optional hex string), as opposed to an optional int_". --- The first commit intention is to improve clarity around the tests purpose, helping reviewers follow what's being verified and why. What started as a small comment during review of #32742 led me reviewing and try to improve most relevant tests comments for consistency and correctness. ACKs for top commit: achow101: ACK ec004cd theStack: lgtm ACK ec004cd #️⃣ yuvicc: ACK ec004cd danielabrozzoni: ACK ec004cd Tree-SHA512: 6a14dedfdc425cd806f63443b3b9f79df69a7717452739f5d7fef1b2bdba23402670d63cf1d6b66c9f1a6b460d4d4a6f185426d0a4982fa95115a234cd6baef7
…in feature_taproot f0524cd functional test: correctly detect nonstd TRUC tx vsize in feature_taproot (Greg Sanders) Pull request description: Resolves #32841 (comment) ACKs for top commit: davidgumberg: utACK f0524cd achow101: ACK f0524cd darosior: utACK f0524cd w0xlt: ACK f0524cd Tree-SHA512: b803c94f7a683b51bab88ae788384ff484a3e6597153bf022263bbc9531dd3faebb7832db26f2b8b4c0d0337c59991d0beca167def5aebe3e9a5d8a9bfdaaba5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.