Fix: replace 'instant' dependency with 'web-time' #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Sorry, I accidentally added a second commit to bump egui versions to this PR. The only changes required for the migration was getting the fonts mutably from the context due to a simple api change. |
Owner
|
@WaffleSoul4 I added commit which merges main here, so egui changes are up to date now as well. |
blitzarx1
approved these changes
Oct 31, 2025
Owner
blitzarx1
left a comment
blitzarx1
left a comment
There was a problem hiding this comment.
lgtm! thanks for addressing this issue.
blitzarx1
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bug
While using this crate, I encounered an error with my project's wasm build that went something like this:
Finding the source
After a little searching, I found this helpful issue on the wasm-bindgen repository. I used this tool (mentioned in the issue) on my project to attempt to find the source of the error, and the source was the instant crate.
Solution
In all regards, web_time seems to be superior to instant. Instant even mentions in their readme that the crate is unmaintained and web_time should be considered as an alternative.