Bump dependency versions. #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly because prometheus 0.13 is vulnerable to https://rustsec.org/advisories/RUSTSEC-2024-0437 as reported in vandry/comprehensive#2 but at the same time we can keep up with the latest version of tonic. This requires bumping our own minor version because dependent crates must follow the same versions of tonic and prometheus.
vandry
added a commit
to vandry/warm_channels
that referenced
this pull request
Oct 26, 2025
Unfortunately blkmlk/tonic-prometheus-layer#5 has sat open without action for too long. Tonic and Prometheus cannot be upgraded in this crate without it.
vandry
added a commit
to vandry/comprehensive
that referenced
this pull request
Oct 26, 2025
Unfortunately blkmlk/tonic-prometheus-layer#5 has sat open without action for too long. Tonic and Prometheus cannot be upgraded in this crate without it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly because prometheus 0.13 is vulnerable to https://rustsec.org/advisories/RUSTSEC-2024-0437 as reported in vandry/comprehensive#2
but at the same time we can keep up with the latest version of tonic.
This requires bumping our own minor version because dependent crates must follow the same versions of tonic and prometheus.