remove search from sidenav

[cynfria]

Category: improvement
User Impact: The sidenav now starts directly with navigation and chats instead of showing a search field.
Problem: The sidenav search field added visual weight to the primary navigation without supporting the intended streamlined layout.
Solution: Remove the search control and its now-unreachable filtering and presentation paths, tighten the top spacing, and preserve the normal chat and settings navigation behavior.

File changes

src/app/views/NavigationPanesView.tsx
Stops passing a search query into the inline session list now that the sidenav no longer owns search state.

src/app/views/tests/NavigationPanesView.test.tsx
Replaces obsolete search interaction coverage with an assertion that the sidenav no longer exposes the search control.

src/features/navigation/ui/PrimaryNavigationSurface.tsx
Removes the sidenav search field, associated state and event handling, and reduces the top inset to 3px.

src/features/sessions/capabilities/SessionListCapability.tsx
Removes the unused search-query API and unreachable filtering and search-mode grouping behavior.

src/features/sessions/ui/session-list/SidebarFlatChatsSection.tsx
Removes unused compact search presentation options.

src/features/sessions/ui/session-list/SidebarProjectsInfoButton.tsx
Updates documentation to describe the remaining hidden-header behavior without referencing removed search mode.

src/features/sessions/ui/session-list/SidebarProjectsSection.tsx
Removes stale search presentation controls while preserving history navigation for overflow chats.

src/features/sessions/ui/session-list/tests/SidebarProjectsInfoButton.test.tsx
Updates test documentation to match the current Projects-header lifecycle.

src/shared/i18n/locales/en/sidebar.json
Removes unused English strings for the deleted jump-to-chat control.

src/shared/i18n/locales/es/sidebar.json
Removes unused Spanish strings for the deleted jump-to-chat control.

Verification

• just check
• pnpm vitest run src/features/sessions/ui/session-list/__tests__ src/app/views/__tests__/NavigationPanesView.test.tsx (169 passed, 1 skipped)

[morgmart]

🤖 Automated code review

COMMENT. Fresh static review completed for the exact three-dot comparison 54e606a...a554230 after applying both the project code-review and wes-review passes. The final self-check covered the removed sidebar-search flow and remaining chat/settings navigation; accessibility; English and Spanish localization cleanup; navigation and consent guards; async, error, never-completes, lifecycle, and race behavior; test honesty; design-system and project rules; duplicate overlap; and concrete evidence plus user effect for severity. One non-blocking design-system finding remains. Supplied GitHub evidence was inspected: all 10 check runs completed successfully at the exact head SHA; the legacy combined status is pending with no statuses, which does not make validation incomplete and required checks still govern merge readiness.

Deterministic publication result: 0 blocking and 1 non-blocking finding(s) publishable; 0 duplicate(s) suppressed.

[morgmart]

🤖 Automated code review

APPROVE. A fresh static review was completed for the exact three-dot comparison 54e606a...f32642a after explicitly applying the project code-review skill and the user wes-review skill. The final self-check covered every changed flow: removal of expanded and collapsed sidebar search, normal grouped and flat session-list behavior, overflow navigation to Session History, main and settings navigation, and the Projects assistive affordance; accessibility and keyboard behavior; English and Spanish localization completeness; navigation and consent guards; async loading, errors, never-completes, lifecycle, and race behavior; test honesty; design-system and project rules; duplicate overlap; and concrete evidence plus user effect for severity. No publishable findings remain. The previous resolved automated spacing concern has been fixed by moving the intentional inset into the shared sidebar token module, so it is neither a finding nor a suppressed duplicate. Supplied GitHub evidence was inspected and is structurally valid at the exact head SHA: five checks succeeded and Frontend checks and unit tests was still in progress; validation is complete, while required checks independently govern merge readiness.

Deterministic publication result: 0 blocking and 0 non-blocking finding(s) publishable; 0 duplicate(s) suppressed.

Pending checks: 3 check(s) are not complete.

This approval reflects the completed code review only; merge readiness remains governed by the repository's required checks.