fix(release): sign updater compatibility metadata without a trailing newline - #40
Merged
Merged
Conversation
kalvinnchau
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Category: fix
User Impact: Future desktop releases can be installed from older Berd versions without a false compatibility-signature failure.
Problem: The release script signed compact compatibility JSON with a trailing newline, while the updater verifies the same JSON serialized without that newline. The one-byte mismatch caused valid release metadata to fail closed during update checks.
Solution: Emit raw compact JSON with
jq -cjnso the producer signs the updater's canonical bytes, and cover the exact payload passed to the signer with a regression test.File changes
scripts/release/sign-compatibility-descriptor.sh
Emit the compatibility descriptor without a trailing newline so its signed bytes match updater verification.
scripts/release/tests/release-scripts.test.mjs
Capture the signer's input and assert it is the exact compact, newline-free canonical payload expected by the updater.
Related issue
None found.
Testing
pnpm test:release-scriptsjust ci