Skip to content

fix: mobile composer, agent draft allowlist, git push DX, duplicate-session warning - #3912

Open
Chessing234 wants to merge 13 commits into
block:mainfrom
Chessing234:fix/multi-issue-batch
Open

fix: mobile composer, agent draft allowlist, git push DX, duplicate-session warning#3912
Chessing234 wants to merge 13 commits into
block:mainfrom
Chessing234:fix/multi-issue-batch

Conversation

@Chessing234

@Chessing234 Chessing234 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Stacked fixes across mobile, CLI/desktop agent drafts, relay auth, and git DX — 11 commits in one PR:

  1. Mobile channel composer: make Enter insert a newline instead of sending #3725 — mobile channel composer: Enter inserts a newline; send stays on the button
  2. feat(cli): owner-reviewed agent drafts cannot grant "Selected people" access — respond-to is limited to owner-only / anyone #3792 — CLI draft-update supports --respond-to allowlist + --respond-to-allowlist
  3. feat(cli): owner-reviewed agent drafts cannot grant "Selected people" access — respond-to is limited to owner-only / anyone #3792 — Desktop round-trips allowlist (stop clearing Selected people on draft apply)
  4. Same agent key running in two places — both reply, nothing detects it #3832 — Relay NOTICE + warn log when a second session auths as the same pubkey
  5. Same agent key running in two places — both reply, nothing detects it #3832 — ACP README: remote-only agents / duplicate-key hazard
  6. Hosted relay git push limited to ~5 MiB packs (code default 500 MB); over-limit and chunked pushes fail opaquely #3802 — Clearer HTTP 413 for over-limit git packs + hydrate ResourceLimit detail
  7. Hosted relay git push limited to ~5 MiB packs (code default 500 MB); over-limit and chunked pushes fail opaquely #3802 — .env.example + git-credential-nostr troubleshooting for postBuffer / pack limits
  8. .env.example: BUZZ_WEB_DIR comment implies it alone serves the web frontend at /, but BUZZ_SERVE_GIT_WEB_GUI is also required #3815 — Startup log distinguishes invite-bundle-only vs full SPA (BUZZ_SERVE_GIT_WEB_GUI)
  9. docs(presence): 90s TTL is documented as 3× a 30s heartbeat, but the agent harness heartbeats at 60s (real margin 1.5×) #3795 — Cross-ref 60s/180s presence invariant at the ACP heartbeat
    10–11. Follow-up tests/docs for the git 413 path

Skipped issues that already have open third-party PRs (#3816, #3857, #3865, #3849, #3885, #3856, #3847).

Test plan

  • cargo test -p buzz-cli --lib agent_management
  • node --test desktop/src/features/agents/agentManagement.test.mjs
  • cargo test -p buzz-relay --lib git_body_limit_message_names_env_var
  • Manual: mobile composer Enter → newline; send button still sends
  • Manual: second buzz-acp with same key → NOTICE in logs
  • Manual: over-limit git push → 413 naming BUZZ_GIT_MAX_PACK_BYTES

Closes #3725
Closes #3792
Closes #3832
Closes #3802
Closes #3795

Made with Cursor

@Chessing234
Chessing234 requested a review from a team as a code owner July 31, 2026 11:55
@Chessing234
Chessing234 force-pushed the fix/multi-issue-batch branch from d7550cb to 482b69b Compare August 1, 2026 11:53
@Chessing234

Chessing234 commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Rebased with Signed-off-by so DCO Check is green.

@Chessing234
fix(mobile): Enter inserts newline in channel composer
4b5fec9 
Match the pulse composer: multiline keyboard with newline action, and
keep send on the visible send button (block#3725).

Signed-off-by: Taksh <takshkothari09@gmail.com>
@Chessing234
feat(cli): support allowlist in agent draft-update
da0913c 
Owner-reviewed drafts can grant Selected people access via
--respond-to allowlist and --respond-to-allowlist (block#3792).

Signed-off-by: Taksh <takshkothari09@gmail.com>
@Chessing234
fix(desktop): round-trip allowlist in owner-reviewed agent drafts
e4ec73e 
Parse respondToAllowlist from draft updates and stop clearing the stored
Selected people list when applying respond-to changes (block#3792).

Signed-off-by: Taksh <takshkothari09@gmail.com>
@Chessing234
fix(relay): warn when a second session auths as the same pubkey
b47eeb5 
Emit a NOTICE (and warn log) on NIP-42 auth when another live connection
already holds the identity, so duplicate agent harnesses are visible (block#3832).

Signed-off-by: Taksh <takshkothari09@gmail.com>
@Chessing234
docs(acp): document remote-only agents and duplicate-key hazard
09bbce3 
Explain why the same agent key must not run on a laptop and a VPS at
once, and point at the relay NOTICE (block#3832).

Signed-off-by: Taksh <takshkothari09@gmail.com>
@Chessing234
fix(relay): return HTTP 413 when git pack body exceeds limit
f4a9bcb 
Map RequestBodyLimitLayer failures to a clear 413 that names
BUZZ_GIT_MAX_PACK_BYTES, and surface hydrate ResourceLimit details (block#3802).

Signed-off-by: Taksh <takshkothari09@gmail.com>
@Chessing234
docs(git): document postBuffer and pack-limit troubleshooting
e1964dd 
Clarify BUZZ_GIT_MAX_PACK_BYTES, http.postBuffer for NIP-98, and opaque
large-push failure modes (block#3802).

Signed-off-by: Taksh <takshkothari09@gmail.com>
@Chessing234
fix(relay): clarify BUZZ_WEB_DIR startup log when web GUI is disabled
c9dbcb7 
Distinguish invite-bundle-only mode from full SPA serving so operators
know they still need BUZZ_SERVE_GIT_WEB_GUI (block#3815).

Signed-off-by: Taksh <takshkothari09@gmail.com>
@Chessing234
docs(acp): cross-reference presence TTL at harness heartbeat
7694e44 
Document the 60s heartbeat / 180s TTL invariant next to the interval
so agent presence docs stay aligned with the relay (block#3795).

Signed-off-by: Taksh <takshkothari09@gmail.com>
@Chessing234
test(relay): cover git pack body-limit 413 mapping
d29915d 
Unit-test the LengthLimitError → HTTP 413 helper used by git_router.

Signed-off-by: Taksh <takshkothari09@gmail.com>
@Chessing234
docs(git-credential-nostr): add large-push troubleshooting rows
c63c08f 
Document postBuffer 401s, pack-limit 413s, and mid-upload TLS aborts.

Signed-off-by: Taksh <takshkothari09@gmail.com>
@Chessing234
fix(relay): rewrite bare git 413 bodies with pack-limit guidance
4b8afa1 
Use axum middleware to replace RequestBodyLimitLayer's empty 413 with a
message that names BUZZ_GIT_MAX_PACK_BYTES.

Signed-off-by: Taksh <takshkothari09@gmail.com>
@Chessing234
Chessing234 force-pushed the fix/multi-issue-batch branch from 482b69b to fd5e12d Compare August 2, 2026 03:58
@Chessing234

Chessing234 commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto latest upstream/main with Signed-off-by on all commits and force-pushed. CI should re-run shortly — still ready for @block/buzz-oss-team review when you have bandwidth.

@Chessing234

Chessing234 commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

@tlongwell-block @wesbillman @wpfleger96 mind taking a look when you get a chance?

@Chessing234

Chessing234 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

multi-issue batch — if review is blocked on scope, i can split mobile composer / draft allowlist / git push dx into separate tips.

@Chessing234
Chessing234 force-pushed the fix/multi-issue-batch branch from fd5e12d to 4b8afa1 Compare August 5, 2026 10:34
@drainodrew drainodrew mentioned this pull request Aug 8, 2026
Open
@Chessing234
Merge remote-tracking branch 'upstream/main' into fix/multi-issue-batch
b29c777 
Signed-off-by: Taksh <takshkothari09@gmail.com>

# Conflicts:
#	mobile/lib/features/channels/compose_bar/layout.dart
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

🔐 Codex Security Review

Status: review required for the current range.

The current range is 59328d5ae38a51a618dd2fddd7faf1343d42096f...b29c7778dfe958f484af47ff5c303afa586155ba.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review b29c7778dfe958f484af47ff5c303afa586155ba to authorize a new review.
Any previous review applies only to its recorded range.

@nathansmithopenclaw-alt nathansmithopenclaw-alt mentioned this pull request Sep 3, 2026
Open
@nathansmithopenclaw-alt

nathansmithopenclaw-alt commented Sep 3, 2026

Copy link
Copy Markdown

Thanks for carrying the selected-people round trip for #3792. We have overlapping
fork work on this seam and do not plan to open a competing allowlist PR.

The interoperability checks that mattered in our implementation were:

  • respondTo: "allowlist" requires at least one canonical pubkey;
  • allowlist identities are normalized and deduplicated before the draft is
    published;
  • unknown request keys are rejected rather than silently discarded;
  • switching to owner-only or anyone does not retain a stale allowlist; and
  • the owner review dialog displays the proposed people and remains editable
    before save.

The remaining design question is create/update parity. draft-create still
cannot propose selected people, while this PR correctly focuses on update. I
suggest keeping that expansion in a separate field-boundary issue so #3912 can
land without absorbing broader create configuration work.

We can help test the strict parser and review-dialog round trip once the PR is
ready; no need to duplicate the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment