fix(channels): preserve canonical member rosters - #7252
Open
Toos00 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Toos00 <164030755+Toos00@users.noreply.github.com>
🔐 Codex Security Review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
39002memberptags in canonical pubkey orderbuzz-admin reconcile-channelspublish rosters through the locked member-snapshot path with a monotonic timestampWhy
nostr::EventBuilderremoves signer self-tags by default. Whenbuzz-admin reconcile-channelssigns a roster with a relay key that is also a canonical channel member, the resulting event can omit that relay owner and fail the database roster fence withkind 39002 roster does not match canonical channel membership.The relay path already uses
allow_self_tagging()after #3777. This change brings the admin reconciliation path to parity and makes roster output deterministic.Validation
cargo fmt --checkcargo test --locked -p buzz-relay group_members_snapshot_ -- --nocapture(3 passed)cargo test --locked -p buzz-admin --bin buzz-admin -- --nocapture(1 passed)The Rust tests were run in
rust:1.88-bookwormwithpkg-configandlibssl-dev, matching the projects documented Linux prerequisites.