fix(relay): correct pagination and counts for existing private queries - #7327
Draft
loganj wants to merge 2 commits into
Draft
fix(relay): correct pagination and counts for existing private queries#7327loganj wants to merge 2 commits into
loganj wants to merge 2 commits into
Conversation
Signed-off-by: Logan Johnson <loganj@squareup.com>
🔐 Codex Security Review
|
Restore the existing development-mode authentication contract. Keep author-only visibility pushdown ahead of pagination and COUNT candidate budgets, with the regression exercising each mode using its existing identity contract. Signed-off-by: Logan Johnson <loganj@squareup.com>
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix pagination and COUNT candidate-budget correctness for existing author-only queries, including the existing reminder event family. Rows that are not visible to the current reader should not consume a visible page or the bounded COUNT fallback's candidate budget.
This is pagination/count correctness only, not authentication hardening or a new private-content feature. No new kinds, schema, lifecycle or client changes. Closest related PR: #7322 (new owner-private intent), unchanged and outside this scope.
Candidate:
5e51c4fa5096f08f20b34d43d09c659ec75e871b(one additive scope-reduction commit over the original draft). Net diff: 4 files, 290 additions / 5 deletions. Original merge-base:01bacb8df3d2f5718e0a468828e07ae874a38eae; no merge commit or history rewrite.Validation on this candidate
Using installed pinned Rust tools and existing dependency caches, offline:
buzz-db122 passed, 252 ignored;buzz-relay1021 passed, 13 failed, 90 ignored. The 13 failures occur at sandbox-denied network operations: six media cases attempting DB fixture setup, six localhost mock/listener cases, and a metrics child reporting Bind instead of RecorderConflict. This is not an all-package pass. Focused passes above overlap with the package run and are not additional unique tests.--no-run); relay/DB all-target clippy with warnings denied passed.Initial remote CI
New-head CI run 33888392074 is in progress. Initial DCO and Desktop Release Candidate checks passed; relay/Rust/PostgreSQL results are not yet available. Skipped review jobs are not review acceptance.
Pending / draft limits
just ci/just testpass. No installs, provisioning or runtime changes were made to obtain a green result.