feat(desktop): list private known Desktops - #7330
Conversation
Signed-off-by: Logan Johnson <loganj@squareup.com>
Signed-off-by: Logan Johnson <loganj@squareup.com>
🔐 Codex Security Review
|
Signed-off-by: Logan Johnson <loganj@squareup.com>
Final-head validation dispositionHead Bounded diagnosis of the three failed jobs:
The affected test/product sources and runner dependencies are unchanged versus the base in the inspected paths. Indirect scheduling effects are not excluded. These are separate maintenance follow-ups, not established Multiverse functional regressions or blanket flake waivers. CODEOWNERS identifies the repository maintainer team, not an assigned individual. Requested failed-job rerun only, unchanged head, attempt 2: https://github.com/block/buzz/actions/runs/33891105430 . Terminal outcome will be recorded separately. No source changes or merge performed. |
Final CI outcomehttps://github.com/block/buzz/actions/runs/33891105430 attempt 2 completed SUCCESS on unchanged head The actual PostgreSQL job 101117686233 executed 380 selected tests: all passed, 1,445 skipped, including the previously failed replica-fence epoch regression and both named private-profile/aged-retry regressions. Status smoke job 101117681166 and workflow smoke job 101117681105 now succeed. The status shard included recovered flaky cases; this is a successful check outcome, not a claim of universally deterministic tests. No source changes or assertion/production guard weakening were used. The earlier maintenance diagnoses remain recorded; a passing rerun does not explain the original masked row or repair the fixture races. Existing native/Core and relay integration successes remain valid. Maintainer review and a live two-Desktop acceptance walkthrough remain distinct gates; no merge, live migration or deployment performed. |
|
Qualification to the successful rerun: the workflow target itself passed on Playwright retry #2 (the first two attempts failed); the shard finished with 326 passed and 8 recovered flaky cases. Its timing/locator maintenance follow-up remains open. Green CI here is not a claim that the workflow test was repaired. |
Current verification — September 4
Exact-head CI SUCCESS, attempt 2: https://github.com/block/buzz/actions/runs/33891105430 . PostgreSQL 380/380 selected tests passed; status smoke and workflow smoke recovered on the same-head rerun. Workflow target passed on Playwright retry #2; the workflow shard had eight recovered flaky cases. No source changes or weakened guards. Earlier local/pending evidence below is historical. Live two-Desktop acceptance remains unperformed; this remains a draft, not a merge or deployment claim.
Summary
Adds a private Known Desktops list to Agents, with generated names and stable, owner/community-scoped installation identities. Startup and reconnect reconcile the local profile independently of the bounded inventory. The UI distinguishes this Desktop, partial results, and failed refreshes without interpreting saved profiles as online or ready to run agents.
Display-only: no hostnames, enrollment, credentials, capability reporting, execution authority, or remote controls. This draft is based directly on
main; freshness and capability UI are separate follow-ups. The larger size of this initial slice has owner approval. No existing PR/issue was found for this scoped private Desktop inventory.Validation
react-day-pickerin the reused dependency cache. Native validation remains blocked by unavailable sherpa-onnx download in the offline environment. No native two-Desktop acceptance or screenshot is claimed.Before leaving draft: exercise two native Desktops with the same owner/community, offline first launch/reconnect, restart identity stability, disconnect retention, and owner/community switching. CI results do not replace that acceptance.
Validation update at
329554051b04e3d9d46e009067dc7d58bcee7711: only the stale test assertion changed from the previously tested production source. Normal exact-head CI is pending; no blanket green claim.Migration
Migration 0045 excludes the new kind from the generated FTS expression and recreates its GIN index. Like the prior FTS migration, it rewrites events under
ACCESS EXCLUSIVE; plan the deployment window accordingly. No migration or runtime deployment was performed while preparing this draft.