fix(relay): preserve query strings during URL normalization - #7450
Open
cuishuang wants to merge 1 commit into
Open
fix(relay): preserve query strings during URL normalization#7450cuishuang wants to merge 1 commit into
cuishuang wants to merge 1 commit into
Conversation
Signed-off-by: cuishuang <imcusg@gmail.com>
🔐 Codex Security Review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix relay URL normalization so query parameters are not modified accidentally.
The previous implementations used string-wide
trim_end_matches('/')andreplace()calls. These operations could alter query values or nested URLs, for example:could become:
and:
could have its nested query URL rewritten.
The updated code parses URLs with
url::Url, changes only the URL scheme and intended path component, and preserves query strings.Related issue
Fixes #
Testing
cargo test -p buzz-core relay::tests --libcargo test -p buzz-cli client::tests --libcargo test -p buzz-acp relay::tests --libcargo clippy -p buzz-core -p buzz-cli -p buzz-acp --all-targets -- -D warningsRegression coverage includes: