fix(desktop): preserve full thread context when opening reply notifications - #7452
Open
JohnRichardEnders wants to merge 1 commit into
Open
fix(desktop): preserve full thread context when opening reply notifications#7452JohnRichardEnders wants to merge 1 commit into
JohnRichardEnders wants to merge 1 commit into
Conversation
🔐 Codex Security Review
|
Signed-off-by: John R. Enders <92937551+JohnRichardEnders@users.noreply.github.com>
JohnRichardEnders
force-pushed
the
fix/thread-notification-context
branch
from
September 7, 2026 15:12
922aab2 to
031df39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix reply notifications opening a thread containing only the clicked reply instead of its root and surrounding conversation.
Notification/search navigation caches a display-only RelayEvent with no reply tags. ChannelRouteScreen inserted that projection before fetching the actual event. useChannelRouteTarget consequently classified it as a root, selected the reply as the thread head, and consumed the route target. Hydrating the real reply afterward did not repair the already-accepted selection.
Defer inserting the cached projection until the existing authoritative event/root/ancestor fetch completes. Merge fetched events first, and retain the projection only as a fallback when the event cannot be fetched. Existing timeline rows remain mounted after the route target clears.
Duplicate check
Searched issues/PRs for notification thread navigation. Closest prior fix is merged #790, which carries the thread root through notification routing. This fixes a later projection/hydration race in that route path, not another notification transport implementation. #6695 concerns displaying replies in the channel timeline.
Testing
Nested notification reply.notification settings drive Inbox badge and desktop alertsintegration case passes, including the cache-only notification fallback.No relay protocol, notification payload, or installed-app configuration changes.