fix(desktop): make starter profiles optional and removable - #7466
Open
JackHunzicker wants to merge 1 commit into
Open
fix(desktop): make starter profiles optional and removable#7466JackHunzicker wants to merge 1 commit into
JackHunzicker wants to merge 1 commit into
Conversation
Signed-off-by: Jack <JLHunzicker@gmail.com>
🔐 Codex Security Review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Starter personas and the built-in Welcome Team are currently forced into every user's inventory and re-created after removal. This PR keeps the templates available by explicit choice instead.
Independent of #7419. Based on
3c7f288c60d67df78577b237e27c3dfc8831aaa1. No change to agent runtime/harness configuration, no second profile store, and the stock template definitions themselves are not removed.Related issue
Fixes #5553 (allow hiding or disabling built-in personas and the Welcome Team). Adjacent, not duplicates: #5979 (channel-membership repair after a completed kickoff; this PR touches
welcomeKickoff.tson one line and should compose with it), #5319 / #6211 (per-device duplicate agents).Testing
cargo test --manifest-path desktop/src-tauri/Cargo.toml --lib --locked). Native regressions cover local-only built-in deletion, custom-team tombstone retention through the same production seam, opt-out survival through the real startup migration/fold, and no automatic Welcome Team re-creation.pnpm test, both globs).pnpm build:e2e(TypeScript check + mock-bridge build) passed.tests/e2e/removable-defaults.spec.ts): 2 passed: starter templates are opt-in and can be removed again; deleting the built-in Welcome Team leaves a custom look-alike team intact.git diff --check, andjust file-size-checkpass.Verified on Windows (x86_64-pc-windows-msvc). The full
just cion this host surfaced a set of pre-existing Windows-only Clippy/test-fixture issues onmainthat are unrelated to this change; I have those fixed locally and will open them as a separate PR so this one stays scoped.Screenshots (mock bridge):