fix(desktop): complete client-only deletion recovery and discovery (follow-up to #7419) - #7467
Open
JackHunzicker wants to merge 5 commits into
Open
fix(desktop): complete client-only deletion recovery and discovery (follow-up to #7419)#7467JackHunzicker wants to merge 5 commits into
JackHunzicker wants to merge 5 commits into
Conversation
Signed-off-by: Michael Lechner <25083998+lechnertech-mike@users.noreply.github.com>
Signed-off-by: Michael Lechner <25083998+lechnertech-mike@users.noreply.github.com>
Signed-off-by: Michael Lechner <25083998+lechnertech-mike@users.noreply.github.com>
Signed-off-by: Michael Lechner <25083998+lechnertech-mike@users.noreply.github.com>
Signed-off-by: Jack <JLHunzicker@gmail.com>
🔐 Codex Security Review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #7419 (device-local agent hosting policy, @lechnertech-mike). This branch is #7419's head
76a1a6e40c3dd3c9c3018748aa1515d8b96ebe3aplus one additional commit; the original commits are untouched and this is offered as an increment on top of that work, not a replacement. Happy to have it pulled into #7419 directly (maintainer-can-modify is set on that PR) or reviewed here, whichever is easier.It closes the gaps Codex flagged in the latest review round on #7419 (
event_sync.rs:22deletion recovery under selective sync,profile.rs:272discovery after policy-load failure,personas/update.rs:175rename duplicates) plus one adjacent hardening:list_relay_agents,list_personas) works through an explicit client-only fallback. The fallback is not persisted over the invalid policy and stored activation state is not rewritten./eventsreceiver is registered in the exact-count egress inventory; no production guard or mutation detector is weakened.docs/agent-device-policy.mddocuments the recovery and discovery behavior.The interrupted-deletion gap predates #7419; this is not a claim that #7419 introduced it. Team deletion is not broadened into managed-agent deletion.
Related issue
#7419, #5319, #6211.
Testing
cargo test --manifest-path desktop/src-tauri/Cargo.toml --lib --locked).pnpm test).pnpm build:e2epassed.tests/e2e/client-only-agents.spec.ts): 2 passed (client-only and unique-name modes keep a stable remote identity as the recipient).git diff --check,just file-size-checkpass.Verified on Windows (x86_64-pc-windows-msvc). Full
just cion this host surfaced pre-existing Windows-only Clippy/test-fixture issues onmainunrelated to this change; those are fixed locally and will go up as a separate PR to keep this scoped. Real two-device relay interoperability has not been exercised here; the native store tests and mock-bridge browser tests are the evidence.