Update test schema with a pure-source (non-indexed) type feeding a top-level sourced_from field - #1356
Merged
ellisandrews-toast merged 1 commit intoAug 17, 2026
Conversation
ellisandrews-toast
requested review from
BrianSigafoos-SQ,
bsorbo,
jwils,
jwondrusch,
marcdaniels-toast,
myronmarston and
rossroberts-toast
as code owners
August 17, 2026 19:57
ellisandrews-toast
force-pushed
the
OLAP-741-top-level-pure-source-type-acceptance
branch
from
August 17, 2026 20:31
d9fae19 to
8f0849a
Compare
myronmarston
approved these changes
Aug 17, 2026
ellisandrews-toast
force-pushed
the
OLAP-741-top-level-pure-source-type-acceptance
branch
from
August 17, 2026 22:07
8f0849a to
2157cd7
Compare
ellisandrews-toast
deleted the
OLAP-741-top-level-pure-source-type-acceptance
branch
August 17, 2026 22:40
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1273. The nested
sourced_fromcase is covered end-to-end by theCoachProfile/GeneralManagerProfiletypes, but we had no coverage proving a top-levelsourced_fromfield can be fed by a pure-source (non-indexed) type.This adds
ComponentDesign— a small pure-source type (not.index) whose events feed a new top-levelComponent.designer_namefield via anindexing_only: truerelationship — plus acceptance coverage intop_level_multi_source_indexing_spec.rb.No library changes were needed — the prior PRs in this stack already handle everything, so this is purely test schema + factory + spec additions and the resulting artifact churn.