feat(send flow): implemented UI changes on flow added a feature flag and some initial work with real sending amount#5331
Conversation
milan-bc
force-pushed
the
feat/FWN-1719-select-send-account-screen
branch
from
bee7966 to
5d1baf3
Compare
milan-bc
force-pushed
the
feat/FWN-1719-select-send-account-screen
branch
2 times, most recently
from
92dd974 to
edcdb32
Compare
milan-bc
force-pushed
the
feat/FWN-1719-select-send-account-screen
branch
from
edcdb32 to
beccc58
Compare
| } | ||
|
|
||
| // helper function to send BTC amount | ||
| const submitBTCTransaction = function* () { |
There was a problem hiding this comment.
We shouldn't need a submitCOINTransaction function, it should be coin agnostic
There was a problem hiding this comment.
yeah this is for testing purpose to try to make at least BTC working then will move it to generic function
| payment = yield payment.sign(password) | ||
| } | ||
| // Publish payment | ||
| if (payPro) { |
| @@ -0,0 +1,510 @@ | |||
| import React from 'react' | |||
There was a problem hiding this comment.
why o why is there yet ANOTHER new enter amount screen? What in the world is wrong with the first one?
There was a problem hiding this comment.
new design and easier to maintain it with feature flag, than to have bund of if/else in original EnterAmount screen then once when feature is out we will just kill old page and make this one main and only one
There was a problem hiding this comment.
just use the old enter amount screen, dont make any changes to it
| <SpinningLoader width='14px' height='14px' borderWidth='3px' /> | ||
| </div> | ||
| ), | ||
| Success: (tx) => ( |
There was a problem hiding this comment.
what is the difference between transactionOverview and confirm?
There was a problem hiding this comment.
this is a new page last step of process, user do confirm and on this page we show again transaction detail and progress like number of confirmations + link to tx explorer
milan-bc
force-pushed
the
feat/FWN-1719-select-send-account-screen
branch
from
beccc58 to
d40f1ed
Compare
blockdylanb
force-pushed
the
development
branch
from
39cc378 to
646afa1
Compare
milan-bc
force-pushed
the
feat/FWN-1719-select-send-account-screen
branch
from
d40f1ed to
310e470
Compare
…and some initial work with real sending amount
milan-bc
force-pushed
the
feat/FWN-1719-select-send-account-screen
branch
from
310e470 to
5887ab7
Compare
| @@ -0,0 +1,119 @@ | |||
| import React from 'react' | |||
There was a problem hiding this comment.
I didn't know this forum I am newB. Learning the byt transfersion world. Better than never. Please do excuse me. I am very happy for finding this although is it stealing?
4 participants
Description (optional)
Add a concise explanation of the changes.
Testing Steps (optional)
Detail the steps required for the reviewer(s) to verify and test these changes.