fix: restore offchain notifications by adopting @anticapture/client 1.2.0#260
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Renames getDaos to daos, adopts supportsCalldataReview/supportsOffchainData field names, coerces bigint runtime values to string in voting power and threshold mappers, and updates proposal() to its new positional signature. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Updates DaoInfo cache type and getDaoInfo return type to the new field names, coerces vote.votingPower to string before formatTokenAmount, and fixes test fixtures to pass bigint literals where the type now requires. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
SDK 1.2.0 returns forVotes/againstVotes/abstainVotes as bigint at runtime; stringify them before dispatching to keep the downstream payload contract. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
SDK 1.2.0 exports the handler as daosHandler (was getDaosHandler) and the DaoInfo response uses supports* field names; align consumers and integrated-tests fixtures with the new shape. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pikonha
approved these changes
May 27, 2026
SettingsService.getUserPreferences now filters out preference rows whose trigger_type is not in the current NotificationTypeId enum, so legacy or manually inserted values in user_notification_preferences cannot break the GET /users/by-channel/:channel/:channelUserId/notification-preferences response. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…gger-types fix: tolerate stale trigger_type values in settings response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@anticapture/clientto 1.2.0 (publishes the renamed REST shape —daosendpoint,supportsCalldataReview/supportsOffchainData, newproposal()signature) so the offchain code path is no longer silently degraded.@notification-system/anticapture-clientwrapper to the new SDK surface, including bigint→string coercions on voting power, deltas, timestamps, and event thresholds.DaoInfocache +buildButtonsmapping) and coerces vote tallies (forVotes/againstVotes/abstainVotes) andvotingPowerto string at the boundaries where downstream still expects strings.getDaosHandler→daosHandler) andDaoInfotest fixtures in consumers + integrated-tests.Context
This is the second half of the incident captured in
INCIDENT_prod-notifications-down.md. The first half (GraphQL → REST endpoint switch) ships via the dev → main merge. This PR is what fixes the silent failure mode where the dispatcher kept running butsupportsOffchainDatawas alwaysfalse, so every offchain-only DAO got skipped.Test plan
pnpm -r build— green across all workspaces.🤖 Generated with Claude Code