feat(multi): add sort order for chain metrics

[lok52]

Summary by CodeRabbit

Release Notes

• New Features

  • Added order parameter to list chains and chain metrics endpoints, enabling control over sort direction (ascending or descending). Defaults to descending order when not specified.

• API Updates

  • Renamed sort_by query parameter to sort in list chains and chain metrics API endpoints for improved naming consistency.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4fd8b26 and 31261c8.

📒 Files selected for processing (6)

• multichain-aggregator/multichain-aggregator-logic/src/services/cluster.rs
• multichain-aggregator/multichain-aggregator-logic/src/types/mod.rs
• multichain-aggregator/multichain-aggregator-logic/src/types/order_direction.rs
• multichain-aggregator/multichain-aggregator-proto/proto/v1/cluster-explorer.proto
• multichain-aggregator/multichain-aggregator-proto/swagger/v1/multichain-aggregator.swagger.yaml
• multichain-aggregator/multichain-aggregator-server/src/services/cluster_explorer.rs

---

Walkthrough

This PR introduces an optional order_direction parameter to the multichain-aggregator's sorting API. A new OrderDirection enum with Asc and Desc variants is added to the types module. The list_chains and list_chain_metrics methods in the cluster service are updated to accept this parameter and apply conditional sort reversal. The proto definitions for ListClusterChainsRequest and ListChainMetricsRequest are modified to rename the sort_by field to sort and add a new order field. Corresponding swagger API definitions and server-side implementations are updated to reflect these changes, including parameter parsing and propagation through the call chain.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat(multi): add list_chain_metrics sort #1618: Modifies the same cluster service sorting APIs (list_chain_metrics and list_chains) by adding sort metric support; this PR extends that work by adding explicit order direction support
• feat(multi): add sorting functionality for list_chains #1612: Added sort-by metric support to the same sorting APIs; this PR builds upon that foundation by introducing an order direction parameter alongside the existing sort capability

Poem

🐰 With whiskers twitching, we arrange,
Ascending paths and descending range,
OrderDirection, shiny new toy,
Sorting chains fills this rabbit with joy! ✨

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch lok52/multi-sort-order

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}