feat: non-regulated fields implementation by matzduniuk · Pull Request #5455 · bloom-housing/bloom

matzduniuk · 2025-10-17T14:40:57Z

This PR addresses #5380

Addresses the issue in full
Addresses only certain aspects of the issue

Description

Update the partners' sites listing form to include new non-regulated fields, including:
- Add HUD EBLL Clearance checkbox field
- Add Deposit and Rent fields
- Add Additional Fees field updates
- Hide yearBuilt, sqFeetMin/ sqFeetMax, floorMin/ floorMax fields for non-regulated listings
Update the required documents section to the new designs
Update existing field labels
Add new Prisma fields for the listing documents,

How Can This Be Tested/Reviewed?

Go to the partner's site dashboard and click the Add Listing button
Select the non-regulated listing type option and a jurisdiction with unit groups enabled
Go through the listing form to verify all new fields have been added.

Author Checklist:

Added QA notes to the issue with applicable URLs
Reviewed in a desktop view
Reviewed in a mobile view
Reviewed considering accessibility
Added tests covering the changes
Made corresponding changes to the documentation
Ran yarn generate: client and/or created a migration when required

Review Process:

Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

…istings-api-layer-updates

* fix: fix schema formatting * chore: add new enum types * chore: add new Listings model fields * chore: add new fields to the UnitGroup model * chore: update DTO's to changes in schema * chore: generate new swagger types * chore: add migration for new schema updates * fix: update depositValue field decimal range * fix: add missing field names * chore: add custom deposit validation decorator * chore: add unit group rent type validation * fix: remove unnecessary import * chore: update sunit summary DTO to contain new fields * chore: update service layer * fix: remove unnecessary migration update * fix: update db fields * chore: update rent validation decorator * chore: add the cocInfo to the listing DTO * chore: regenerate backend swagger * chore: add listing type selector * chore: add unit form non regulated rent fields * fix: fix invalid logic * chore: update prop to and optional value * chore: add rent type fields for unit group form * chore: hide additional fields for non regulated listings * chore: add fields for the deposit types * chore: update labels * chore: update community types fields * chore: add listing ebll clearance field * chore: update built year filed rendering logic * chore: fix field decorator error * fix: fix decorators import paths * chore: update required documents form fields * chore: update the schema to include the new required documents list table * fix: remove unused import * chore: update listings factory to include the new required documents field * chore: hide non regulated switch field based on feature flag * chore: retain the original required documents field * Revert "chore: hide non regulated switch field based on feature flag" This reverts commit 11f0874. * fix: add missing fields validation * fix: update imports * fix: remove the package manager filed in package JSON * fix: update the hasHudEbllClearance field * fix: remove unused import * chore: update the label to match the current listing type * fix: fix the application fee full width field * fix: hide the new deposit and rent fields for regulated units * fix: boolean ebll formatting for form submission * chore: add non regulated listing fields to intro and fees sections * chore: add missing documents model column mapping * fix: udpdate form subssion for the new required documents field * chore: add required documents preview in the details * fix: add feature flag based regulated fields control * chore: update the validation decorator * chore: update listing details page to new jest standard * fix: fix failing backend API tests * fix: fix backend integration tests * fix: fix decorator logic * fix: add unit group rent range revalidation triggering * fix: fix unwanted initial ebll field reset * fix: required documents preview filtering * fix: update the developer field title switching on listing preview page * fix: hide new fields on listing preview based on the non-regulated feature flag * fix: fix label typo * fix: update new required documents field label formatting * fix: hide the new documents field group on regulated listings * fix: remove unused import * fix: add missing monthly rent field to database * fix: fix unit groups integration tests * fix: paper listing form failing tests * chore: rename migration files * fix: clean-up merge conflict resolve * fix: remove unnecessary listing service code * fix: hide the new required documents field from preview page based on feature flag * fix: remove unused prop * fix: update the listings factory to add new required documents only for non regulated mocks * chore: add logic to disconnect and delete documents table entry automatically * fix: fix Units component feature flag detection code * chore: add integration tests for non regulated listing preview * chore: add integration tests for the ListingIntro section * chore: add integration tests for AdditionalDetails form section component * chore: add deposit type default field for the listing form * chore: add integration tests for the AdditionalFees listing form component * chore: add integration tests for the unit group form for non-regulated listing * fix: update the listing service to remove the documents entry after completed transaction * fix: revert the CommunityType component logic * chore: partially revert additional fees section logic * fix: update the listingType field clearing to undefined * fix: remove unused imports * fix: revert changes for unit form * test: re-run testing suite * chore: remove the depositRangeMin and depositRangeMax fields * chore: update the data formatter to handle different deposit type values * fix: update api integration tests to new changes * fix: fix csv export integration tests * test: re-run testing suite * fix: update partners site integration tests * test: re-run testing suite * fix: remove unnecessary console log * fix: clear deposit on save and continue (bloom-housing#5598) --------- Co-authored-by: Morgan Ludtke <42942267+ludtkemorgan@users.noreply.github.com>

matzduniuk and others added 30 commits September 22, 2025 11:46

fix: fix schema formatting

682fa60

chore: add new enum types

6db2a67

chore: add new Listings model fields

6ee3134

chore: add new fields to the UnitGroup model

19e2d5e

chore: update DTO's to changes in schema

a082fd7

chore: generate new swagger types

2dcb632

chore: add migration for new schema updates

ca450a1

fix: update depositValue field decimal range

9a6d37d

Merge branch 'main' into 5376/database-schema-updates

4b9c250

Merge branch 'main' into 5376/database-schema-updates

1bcf860

fix: add missing field names

f05c50d

chore: add custom deposit validation decorator

7d78997

chore: add unit group rent type validation

cdd4c2a

fix: remove unnecessary import

ceb9ee8

chore: update sunit summary DTO to contain new fields

b39299a

chore: update service layer

dfc3173

fix: remove unnecessary migration update

ada8d52

fix: update db fields

eeb5bfa

Merge branch '5376/database-schema-updates' into 5377/non-regulated-l…

e506251

…istings-api-layer-updates

chore: update rent validation decorator

5250427

chore: add the cocInfo to the listing DTO

1bf8c66

chore: regenerate backend swagger

da79ff3

chore: add listing type selector

bde59a9

chore: add unit form non regulated rent fields

f3d8fdb

fix: fix invalid logic

84fa3c5

chore: update prop to and optional value

8a1300e

chore: add rent type fields for unit group form

51e13db

chore: hide additional fields for non regulated listings

1d6a74b

chore: add fields for the deposit types

53b3a6b

chore: update labels

460d55a

matzduniuk requested a review from ludtkemorgan November 14, 2025 10:25

matzduniuk and others added 4 commits November 14, 2025 20:30

fix: revert changes for unit form

09ec8e0

Merge branch 'main' into 5380/non-regulated-fields-implementation

2ae4837

Merge branch 'main' into 5380/non-regulated-fields-implementation

f605050

test: re-run testing suite

c3e16bf

This comment was marked as resolved.

Sign in to view

matzduniuk and others added 5 commits November 18, 2025 09:25

Merge branch 'main' into 5380/non-regulated-fields-implementation

987b734

chore: remove the depositRangeMin and depositRangeMax fields

d60363f

chore: update the data formatter to handle different deposit type values

0baa29c

fix: update api integration tests to new changes

8952aeb

fix: fix csv export integration tests

98b5456

matzduniuk force-pushed the 5380/non-regulated-fields-implementation branch from 7519e1d to 98b5456 Compare November 18, 2025 12:37

matzduniuk requested a review from ludtkemorgan November 18, 2025 14:47

matzduniuk added 3 commits November 18, 2025 15:47

test: re-run testing suite

edb77e1

fix: update partners site integration tests

1efbca4

test: re-run testing suite

a3d85a1

This comment was marked as resolved.

Sign in to view

ludtkemorgan mentioned this pull request Nov 18, 2025

fix: clear deposit on save and continue #5598

Merged

matzduniuk and others added 2 commits November 19, 2025 13:58

fix: remove unnecessary console log

0a2b691

fix: clear deposit on save and continue (#5598)

545fbb8

mcgarrye added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Nov 19, 2025

Merge branch 'main' into 5380/non-regulated-fields-implementation

cd9453d

matzduniuk merged commit 27d8f00 into main Nov 20, 2025
34 checks passed

matzduniuk deleted the 5380/non-regulated-fields-implementation branch November 20, 2025 08:04

ludtkemorgan mentioned this pull request Nov 24, 2025

release: end of november 2025 metrotranscom/doorway#1468

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: non-regulated fields implementation#5455

feat: non-regulated fields implementation#5455
matzduniuk merged 116 commits into
mainfrom
5380/non-regulated-fields-implementation

matzduniuk commented Oct 17, 2025

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

matzduniuk commented Oct 17, 2025

Description

How Can This Be Tested/Reviewed?

Author Checklist:

Review Process:

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants