Skip to content

fix: put support admin behind feature flag#5521

Merged
ludtkemorgan merged 2 commits into
mainfrom
5503/support-admin
Nov 6, 2025
Merged

fix: put support admin behind feature flag#5521
ludtkemorgan merged 2 commits into
mainfrom
5503/support-admin

Conversation

@ludtkemorgan

Copy link
Copy Markdown
Collaborator

This PR addresses #5503

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

The new support admin was accidentally not put behind the feature flag created for it. In other words now in jurisdictions that don't want the new role can create a user with this permission level

How Can This Be Tested/Reviewed?

The new feature flag is enabled by default for Bloomington jurisdiction. The following three scenarios should be tested after a new reseed

  1. Login as an admin to the partner portal. Go to the /users page and go to "add user". You should see the new role in the dropdown.
  2. Login as a jurisdictional admin to the partner portal. Go to the /users page and go to "add user". You should NOT see the new role in the dropdown.
  3. Turn off "enableSupportAdmin" for all jurisdictions. Login as an admin to the partner portal. Go to the /users page and go to "add user". You should NOT see the new role in the dropdown.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@netlify

netlify Bot commented Oct 31, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-flagly ready!

Name Link
🔨 Latest commit b74bc2d
🔍 Latest deploy log https://app.netlify.com/projects/bloom-flagly/deploys/690b8a3c8db5d30007aa1167
😎 Deploy Preview https://deploy-preview-5521--bloom-flagly.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Oct 31, 2025

Copy link
Copy Markdown

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit b74bc2d
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/690b8a3c5dc7bc00087bf83f
😎 Deploy Preview https://deploy-preview-5521--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ludtkemorgan ludtkemorgan added the 1 review needed Requires 1 more review before ready to merge label Oct 31, 2025
@netlify

netlify Bot commented Oct 31, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit b74bc2d
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/690b8a3c41cf0200089850d6
😎 Deploy Preview https://deploy-preview-5521--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Oct 31, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit b74bc2d
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/690b8a3cffc3d0000823923d
😎 Deploy Preview https://deploy-preview-5521--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Oct 31, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-lakeview ready!

Name Link
🔨 Latest commit b74bc2d
🔍 Latest deploy log https://app.netlify.com/projects/bloom-lakeview/deploys/690b8a3c360a160009998c90
😎 Deploy Preview https://deploy-preview-5521--bloom-lakeview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@emilyjablonski emilyjablonski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't had a chance to do a full review, but if we don't add the flag with a description to feature-flags-enum.ts, then it doesn't get added when we run the script

Comment thread sites/partners/src/components/users/FormUserManage.tsx
@millord millord self-requested a review November 4, 2025 17:18
@ludtkemorgan

Copy link
Copy Markdown
Collaborator Author

@emilyjablonski The feature flag was added in an earlier PR, including the description in feature-flag-enum.ts, we just accidentally didn't connect the actual feature behind the flag

@mcgarrye mcgarrye added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Nov 4, 2025
@ludtkemorgan ludtkemorgan merged commit 1b9eb2e into main Nov 6, 2025
30 checks passed
@ludtkemorgan ludtkemorgan deleted the 5503/support-admin branch November 6, 2025 22:18
mcgarrye pushed a commit to metrotranscom/doorway that referenced this pull request Nov 10, 2025
* fix: put support admin behind feature flag

* fix: linting errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Should be applied when a PR has been reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants