fix: neighborhood amenities remove sections#5536
Merged
Merged
Conversation
KrissDrawing
added
the
1 review needed
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-flagly canceled.
|
✅ Deploy Preview for bloom-lakeview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
KrissDrawing
changed the title
emilyjablonski
requested changes
Nov 4, 2025
Collaborator
There was a problem hiding this comment.
This is awesome! My only comments are non-blocking on style.
There is one UI state I think we should adjust, which is before you have selected a jurisdiction, it shows as an empty section. We keep running into cases like this as we change behavior across jurisdictions and eventually will likely make a user pre-select a jurisdiction before they ever get to the edit page. But, for now I'd recommend we not show the section at all until we have a jurisdiction, as a jurisdiction could have no amenities at all or have the feature flag disabled.
emilyjablonski
added
needs changes
Collaborator
|
We can also wait on bus stops as we have this ticket comin up: #5498 |
KrissDrawing
added
1 review needed
emilyjablonski
added
ready to merge
mcgarrye
added a commit
to metrotranscom/doorway
that referenced
this pull request
Nov 6, 2025
* feat: add visible neighborhood amenities to jurisdictions and update related components * fix: add option to seed visibleNeighborhoodAmenities * fix: show just visible neighborhood amenities in csv export * test: fix * refactor: use enum to map amenities * fix: hide neighborhood amenities section when no jurisdiction selected --------- Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #5477
Description
Adds new column in jurisdictions table (visibleNeighborhoodAmenities). It populates as default for current state of amenites.
I got to sligthly refactor
NeighborhoodAmenities.tsxso it looks good for each variation (Also changedDetailNeighborhoodAmenities.tsxfor consistency).For seed-staging i've added visibleNeighborhoodAmenities for
Angelopolisso it shows justGrocery StoresandPharmacies(Not sure if i should also addBus stopfield in this task, if so it shouldn't be huge change)How Can This Be Tested/Reviewed?
Relevant changes in
schema.prismaare line 399 and 1300-1309 (rest are justprisma format)Either run migration, or setup new staging-seed.
angelopolisjurisdiction.Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: