Skip to content

fix: [5441]-waitlist-lotteries-allow-selection-fcfs-fixes#5548

Merged
millord merged 9 commits into
mainfrom
5441/waitlist-lotteries-allow-selection-fcfs-fixes
Nov 6, 2025
Merged

fix: [5441]-waitlist-lotteries-allow-selection-fcfs-fixes#5548
millord merged 9 commits into
mainfrom
5441/waitlist-lotteries-allow-selection-fcfs-fixes

Conversation

@millord

@millord millord commented Nov 5, 2025

Copy link
Copy Markdown
Collaborator

This PR addresses #5441

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Please include a summary of the change and which issue(s) is addressed.

How Can This Be Tested/Reviewed?

  1. As a partner user start creating a listing.
  2. Fill it with the required data and for the question-> What is the listing availability? select Open waitlist.
  3. Navigate to the Application process tab. For How is the application review order determined? select Lottery and fill up the fields for:
    - When will the lottery be run?
    - Lottery start time
    - Lottery end time
  4. Click on Submit
  5. Log out and log in as an admin user
  6. Search for the listing created
  7. Click on edit
    • verify that in the What is the listing availability? question the Open waitlist radio button is still selected.
    • Navigate to the application process tab and verify that for the question How is the application review order determined? the Lottery radio button is selected and that the lottery information is persisted.
  8. Approve and publish the listing
  9. Click on Edit and then close the listing - Lottery tab should show
  10. Click in run lottery
  11. Release the lottery to partners
  12. Update the your partner user to relate to that listing
  13. Log out and login as a partner user
  14. Search for the listing
  15. Go to the lottery tab and click on Publish

Provide instructions so we can review, including any needed configuration, and the test cases that need to be QAd.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@millord millord changed the title fixing logic issue fix: [5441]-waitlist-lotteries-allow-selection-fcfs-fixes Nov 5, 2025
@netlify

netlify Bot commented Nov 5, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-flagly ready!

Name Link
🔨 Latest commit c2fc4ff
🔍 Latest deploy log https://app.netlify.com/projects/bloom-flagly/deploys/690ca39ce020aa0008794430
😎 Deploy Preview https://deploy-preview-5548--bloom-flagly.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Nov 5, 2025

Copy link
Copy Markdown

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit c2fc4ff
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/690ca39b755ed6000801fc06
😎 Deploy Preview https://deploy-preview-5548--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@millord millord marked this pull request as ready for review November 5, 2025 14:09
@netlify

netlify Bot commented Nov 5, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-angelopolis canceled.

Name Link
🔨 Latest commit c2fc4ff
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/690ca39cc0928e0008e91576

@ludtkemorgan ludtkemorgan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding those tests!

@ludtkemorgan ludtkemorgan added the ready to merge Should be applied when a PR has been reviewed and approved label Nov 6, 2025
@netlify

netlify Bot commented Nov 6, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-lakeview ready!

Name Link
🔨 Latest commit c2fc4ff
🔍 Latest deploy log https://app.netlify.com/projects/bloom-lakeview/deploys/690ca39c5d75d000088155d8
😎 Deploy Preview https://deploy-preview-5548--bloom-lakeview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Nov 6, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit c2fc4ff
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/690ca39b862aaf0008d903ec
😎 Deploy Preview https://deploy-preview-5548--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Nov 6, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit c2fc4ff
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/690ca39c68606e0008d36ec0
😎 Deploy Preview https://deploy-preview-5548--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@millord millord merged commit ca60911 into main Nov 6, 2025
34 checks passed
@millord millord deleted the 5441/waitlist-lotteries-allow-selection-fcfs-fixes branch November 6, 2025 13:47
mcgarrye pushed a commit to metrotranscom/doorway that referenced this pull request Nov 6, 2025
…ing#5548)

fixing logic and adding tests for waitlist lottery changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Should be applied when a PR has been reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants