Skip to content

feat: add neighborhood amenities as dropdowns#5553

Merged
KrissDrawing merged 6 commits into
mainfrom
5475/Neighborhood-Amenities-Change-input-type-to-dropdown
Nov 12, 2025
Merged

feat: add neighborhood amenities as dropdowns#5553
KrissDrawing merged 6 commits into
mainfrom
5475/Neighborhood-Amenities-Change-input-type-to-dropdown

Conversation

@KrissDrawing

Copy link
Copy Markdown
Collaborator

This PR addresses #5475

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Adds option to display neighborhood amenities as dropdowns (while enableNeighborhoodAmenitiesDropdown flag is true)

How Can This Be Tested/Reviewed?

Seed data or add enableNeighborhoodAmenitiesDropdown flag.
On partners site switch to angelopolis, now neighborhood amenities should have dropdowns instead of textfields

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@KrissDrawing KrissDrawing added the 1 review needed Requires 1 more review before ready to merge label Nov 6, 2025
@netlify

netlify Bot commented Nov 6, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-angelopolis canceled.

Name Link
🔨 Latest commit cb93b63
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/69141f0b7231cf00081a6a20

@netlify

netlify Bot commented Nov 6, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-flagly canceled.

Name Link
🔨 Latest commit cb93b63
🔍 Latest deploy log https://app.netlify.com/projects/bloom-flagly/deploys/69141f0b918a1a000837d24b

@netlify

netlify Bot commented Nov 6, 2025

Copy link
Copy Markdown

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit cb93b63
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/69141f0bf9a10800089758bc
😎 Deploy Preview https://deploy-preview-5553--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@emilyjablonski emilyjablonski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect!

Just would love to see a test - I missed this on my review of the last one and added em in this PR that's up, as an example of all the setup these listing edit sections need as I don't think this section has any tests yet: #5550

@emilyjablonski emilyjablonski added needs changes The author must make changes and then re-request review before merging and removed 1 review needed Requires 1 more review before ready to merge labels Nov 6, 2025
@KrissDrawing KrissDrawing added 1 review needed Requires 1 more review before ready to merge and removed needs changes The author must make changes and then re-request review before merging labels Nov 10, 2025

@emilyjablonski emilyjablonski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, tysm for the new test file!

@emilyjablonski emilyjablonski added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Nov 10, 2025
@KrissDrawing KrissDrawing merged commit 259b2b0 into main Nov 12, 2025
34 checks passed
@KrissDrawing KrissDrawing deleted the 5475/Neighborhood-Amenities-Change-input-type-to-dropdown branch November 12, 2025 06:27
mcgarrye pushed a commit to metrotranscom/doorway that referenced this pull request Nov 19, 2025
* feat: add neighborhood amenities as dropdowns

* fix: switch array to enum

* test: add test for NeighborhoodAmenities partners section

* test: add options check for select
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Nov 24, 2025
* feat: add neighborhood amenities as dropdowns

* fix: switch array to enum

* test: add test for NeighborhoodAmenities partners section

* test: add options check for select
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Dec 8, 2025
* feat: add neighborhood amenities as dropdowns

* fix: switch array to enum

* test: add test for NeighborhoodAmenities partners section

* test: add options check for select
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Should be applied when a PR has been reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants