fix: pass the jurisdiction id to edit unit form#5555
Merged
Conversation
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-lakeview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-flagly ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ludtkemorgan
added
the
1 review needed
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ludtkemorgan
commented
Nov 6, 2025
ludtkemorgan
force-pushed
the
5554/ami-charts
branch
from
f9b8b7c to
b25fbf1
Compare
mcgarrye
added
ready to merge
ludtkemorgan
force-pushed
the
5554/ami-charts
branch
from
b25fbf1 to
33f62a7
Compare
9 tasks
mcgarrye
pushed a commit
to metrotranscom/doorway
that referenced
this pull request
Nov 10, 2025
* fix: pass the jurisdiction id to edit unit form * fix: remove unused dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #5554
Description
With a recent fix for unit management the selected jurisdiction id was not getting picked up when requesting AMI chart data. This means that all jurisdiction AMI charts were being returned even if you have already selected a jurisdiciton for the listing. A small refactor was needed to pass the jurisdiction id to the User and UserGroup forms instead of relying on the useFormContext.
Also, I noticed that "add unit groups" was the default option if any of the jurisdictions have that enabled. This PR changes that functionality to only display unit group form if either all jurisdictions have enableUnitGroups set or the selected jurisdiction does.
Additional tests were added, but since there were no tests for this file I just added one generic test and one for this specific field. All other suggested tests are added as todos. Note these don't test the actually issue that happened because it required the correct jurisdiction id to be passed to the component. That is a larger test that should be added to
PaperListingForm/index.test.tsxHow Can This Be Tested/Reviewed?
The unit group flow:
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: