Skip to content

feat: add listing file number#5558

Merged
KrissDrawing merged 4 commits into
mainfrom
5485/New-listing-field-Listing-file-number
Nov 17, 2025
Merged

feat: add listing file number#5558
KrissDrawing merged 4 commits into
mainfrom
5485/New-listing-field-Listing-file-number

Conversation

@KrissDrawing

Copy link
Copy Markdown
Collaborator

This PR addresses #5485

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Adds listing file number field to listing create / update form behin feature flag.

How Can This Be Tested/Reviewed?

After reseed / or migrate and add feature flag enableListingFileNumber .
Go to edit / add listng form and switch to angelopolis it should show listing file number, you should be able to add it and show in details. Also it will be exported in csv.
Probably will need to add a tests after PR with ListingIntro tests will be merged.
So i guess it's a bit on hold

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@KrissDrawing KrissDrawing added the 1 review needed Requires 1 more review before ready to merge label Nov 10, 2025
@netlify

netlify Bot commented Nov 10, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-flagly canceled.

Name Link
🔨 Latest commit 1095709
🔍 Latest deploy log https://app.netlify.com/projects/bloom-flagly/deploys/69175620dbaa1a0008dc100d

@netlify

netlify Bot commented Nov 10, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-angelopolis canceled.

Name Link
🔨 Latest commit 1095709
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/69175620dbaa1a0008dc100f

@netlify

netlify Bot commented Nov 10, 2025

Copy link
Copy Markdown

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 1095709
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/691756200b5a270008ffd026
😎 Deploy Preview https://deploy-preview-5558--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@emilyjablonski

Copy link
Copy Markdown
Collaborator

The ListingIntro tests have been merged 🫡

@emilyjablonski emilyjablonski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change I see here is that the field should not show before we have selected a jurisdiction - other than that and tests, lgtm!

@emilyjablonski emilyjablonski added needs changes The author must make changes and then re-request review before merging and removed 1 review needed Requires 1 more review before ready to merge labels Nov 13, 2025
@KrissDrawing KrissDrawing added 1 review needed Requires 1 more review before ready to merge and removed needs changes The author must make changes and then re-request review before merging labels Nov 14, 2025

@emilyjablonski emilyjablonski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@emilyjablonski emilyjablonski added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Nov 14, 2025
@KrissDrawing KrissDrawing merged commit 445ad4f into main Nov 17, 2025
34 checks passed
@KrissDrawing KrissDrawing deleted the 5485/New-listing-field-Listing-file-number branch November 17, 2025 06:47
mcgarrye pushed a commit to metrotranscom/doorway that referenced this pull request Nov 19, 2025
* feat: add listing file number

* fix: hide listing file number when no jurisdiction selected

* test: add tests for listing file number
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Nov 24, 2025
* feat: add listing file number

* fix: hide listing file number when no jurisdiction selected

* test: add tests for listing file number
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Dec 8, 2025
* feat: add listing file number

* fix: hide listing file number when no jurisdiction selected

* test: add tests for listing file number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Should be applied when a PR has been reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants