Skip to content

feat: add additional neighborhood amenities#5563

Merged
KrissDrawing merged 3 commits into
mainfrom
5498/Neighborhood-Amenities-New-Drop-Downs
Nov 17, 2025
Merged

feat: add additional neighborhood amenities#5563
KrissDrawing merged 3 commits into
mainfrom
5498/Neighborhood-Amenities-New-Drop-Downs

Conversation

@KrissDrawing

@KrissDrawing KrissDrawing commented Nov 12, 2025

Copy link
Copy Markdown
Collaborator

This PR addresses #5498

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Adds new entries to NeighborhoodAmenities enum, and new columns to NeighborhoodAmenities table. Adds them to Angelopolis seed to they will display on partners site, and after filling on public.
Translations are google translate fyi

How Can This Be Tested/Reviewed?

Reseed data.
Now on partners add / edit listing. For "Angelopolis" it should have new fields. Test if they appear in details, and on public listing site (with translations). Also check csv export (if any jurisdiction has them visible, they should appear)

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@KrissDrawing KrissDrawing added the 1 review needed Requires 1 more review before ready to merge label Nov 12, 2025
@netlify

netlify Bot commented Nov 12, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-flagly ready!

Name Link
🔨 Latest commit e05964f
🔍 Latest deploy log https://app.netlify.com/projects/bloom-flagly/deploys/691759ed07c6110008492e8b
😎 Deploy Preview https://deploy-preview-5563--bloom-flagly.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Nov 12, 2025

Copy link
Copy Markdown

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit e05964f
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/691759edc544ee0008814e61
😎 Deploy Preview https://deploy-preview-5563--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Nov 12, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-angelopolis ready!

Name Link
🔨 Latest commit e05964f
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/691759edfd26ae0008949fa8
😎 Deploy Preview https://deploy-preview-5563--bloom-angelopolis.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@emilyjablonski emilyjablonski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs one change!

Not your fault at all, the AC had an error - Senior center should be Senior centers so that each option is plural. Gonna approve bc that should be a small fix!

@emilyjablonski emilyjablonski removed the 1 review needed Requires 1 more review before ready to merge label Nov 13, 2025
@netlify

netlify Bot commented Nov 14, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit e05964f
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/691759ed2fd32c0008f64629
😎 Deploy Preview https://deploy-preview-5563--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Nov 14, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-lakeview ready!

Name Link
🔨 Latest commit e05964f
🔍 Latest deploy log https://app.netlify.com/projects/bloom-lakeview/deploys/691759edde40290008c20735
😎 Deploy Preview https://deploy-preview-5563--bloom-lakeview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Nov 14, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit e05964f
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/691759ed0b5a2700080108fa
😎 Deploy Preview https://deploy-preview-5563--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@KrissDrawing KrissDrawing added the ready to merge Should be applied when a PR has been reviewed and approved label Nov 17, 2025
@KrissDrawing KrissDrawing merged commit 51d6c9c into main Nov 17, 2025
34 of 35 checks passed
@KrissDrawing KrissDrawing deleted the 5498/Neighborhood-Amenities-New-Drop-Downs branch November 17, 2025 06:51
mcgarrye pushed a commit to metrotranscom/doorway that referenced this pull request Nov 19, 2025
* feat: add additional neighborhood amenities

* test: add new neighborhood amenities to listing service test

* fix: switch senior center to senior centers
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Nov 24, 2025
* feat: add additional neighborhood amenities

* test: add new neighborhood amenities to listing service test

* fix: switch senior center to senior centers
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Dec 8, 2025
* feat: add additional neighborhood amenities

* test: add new neighborhood amenities to listing service test

* fix: switch senior center to senior centers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Should be applied when a PR has been reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants