You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ran yarn generate:client and/or created a migration when required
Review Process:
Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates
Hey @avrittrohwer this looks good and I think you're good to merge, but you should double check the gitLeaks hook that is failing on this pr to make sure its not something we need to address
Hey @avrittrohwer this looks good and I think you're good to merge, but you should double check the gitLeaks hook that is failing on this pr to make sure its not something we need to address
yeah the gitleak is triggering on the docker image git sha ghcr.io/bloom-housing/bloom/api:gitsha-f642fc1f3f056b9fa53429c4fa81689c5e856e5a"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infraA way to track issues that are specific to bloom infrastructural changesready to mergeShould be applied when a PR has been reviewed and approved
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #5450
This PR addresses #5438
Description
Bloom-dev AWS deployment initial infra. Contains:
The deployment is currently live at:
https://core-dev.bloomhousing.dev/
https://partners.core-dev.bloomhousing.dev/
I manually seeded the database with the staging seed command. I will followup automation of that when I add the deployment automation.
How Can This Be Tested/Reviewed?
cd infra/tofu_root_modules/bloom_devtofu destroy -target=module.bloom_deploymenttofu applybloom-devas SystemAdministrator.Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: