Skip to content

fix: switch rtl phone numbers to ltr #6243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KrissDrawing wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: switch rtl phone numbers to ltr #6243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3bfe8d
fix: switch rtl phone numbers to ltr
KrissDrawing Apr 29, 2026
ecce87b
Merge branch 'main' into 6083/Translation-issues-RTL-phone-numbers-core
emilyjablonski May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shared-helpers/src/locales/ar.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@
"application.contact.givenName": "الاسم الأول",
"application.contact.mailingAddress": "عنوان البريد",
"application.contact.noPhoneNumber": "ليس لدي رقم هاتف",
"application.contact.number.subNote": "10 أرقام، على سبيل المثال 999-999-9999",
"application.contact.number.subNote": "10 أرقام، على سبيل المثال \u2066999-999-9999\u2069",
"application.contact.number": "رقم",
"application.contact.phoneNumberTypes.cell": "زنزانة",
"application.contact.phoneNumberTypes.home": "الصفحة الرئيسية",
Expand Down
2 changes: 1 addition & 1 deletion shared-helpers/src/locales/fa.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@
"application.contact.givenName": "نام داده شده",
"application.contact.mailingAddress": "آدرس پستی",
"application.contact.noPhoneNumber": "شماره تلفن ندارم",
"application.contact.number.subNote": "ده رقمی، مثلاً ۹۹۹-۹۹۹-۹۹۹۹",
"application.contact.number.subNote": "ده رقمی، مثلاً \u2066999-999-9999\u2069",
"application.contact.number": "شماره",
"application.contact.phoneNumberTypes.cell": "سلول",
"application.contact.phoneNumberTypes.home": "خانه",
Expand Down
6 changes: 3 additions & 3 deletions sites/public/src/components/shared/FormSummaryDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ const FormSummaryDetails = ({
}
className={styles["summary-value"]}
>
{application.applicant.phoneNumber}
<span dir="ltr">{application.applicant.phoneNumber}</span>
</FieldValue>
)}
{application.additionalPhoneNumber && (
Expand All @@ -367,7 +367,7 @@ const FormSummaryDetails = ({
}
className={styles["summary-value"]}
>
{application.additionalPhoneNumber}
<span dir="ltr">{application.additionalPhoneNumber}</span>
</FieldValue>
)}
{application.applicant.emailAddress && (
Expand Down Expand Up @@ -485,7 +485,7 @@ const FormSummaryDetails = ({
label={t("t.phone")}
className={styles["summary-value"]}
>
{application.alternateContact.phoneNumber}
<span dir="ltr">{application.alternateContact.phoneNumber}</span>
</FieldValue>
)}

Expand Down
Loading