fix: add sub jurisdictions to allow multiple jurisdictions in search#6323
Open
ludtkemorgan wants to merge 5 commits into
Open
fix: add sub jurisdictions to allow multiple jurisdictions in search#6323ludtkemorgan wants to merge 5 commits into
ludtkemorgan wants to merge 5 commits into
Conversation
✅ Deploy Preview for partners-bloom-msq2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ludtkemorgan
force-pushed
the
5985/sub-jurisdictions
branch
from
c61b527 to
1576b22
Compare
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ludtkemorgan
added
the
1 review needed
Collaborator
|
The seed is for |
mcgarrye
approved these changes
May 27, 2026
Collaborator
mcgarrye
left a comment
mcgarrye
left a comment
There was a problem hiding this comment.
Looks good, no major issues. Few callouts
- Home page of public site does not display the correct jurisdiction name
- If the sub jurisdictions have the enableListingMap set to true, but the top level jurisdiction does not, we follow the top level. This makes sense but we should document
- We don't need to account for non-seeds going forward, correct?
mcgarrye
added
ready to merge
ludtkemorgan
force-pushed
the
5985/sub-jurisdictions
branch
from
b4e1e10 to
4a79c72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #5985
Description
With a region based search we need to be able fetch listings from multiple jurisdictions tied to the higher level jurisdiction.
This PR adds a new field to the jurisdiction table called
sub_jurisdictionsthat has the ids of all jurisdictions tied to that jurisdiction. For example in Doorway the "Bay Area" jurisdiction would have sub jurisdictions of all of the individual counties in the bay area.Additionally, I noticed we were both returning more data than needed in the get jurisdictions endpoint as well as calling this endpoint in more places than we should have. This PR does the following:
selectof just the fields we need rather than anincludeHow Can This Be Tested/Reviewed?
This can be tested with the new "Bay Bridge" and sub jurisdictions
yarn setup:regionenableListingMapfeature flag and restart the public site. In the list view you should also see listings from all jurisdictionsAuthor Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: