Skip to content

feat: email unsubscribe and settings link#6340

Open
matzduniuk wants to merge 12 commits into
mainfrom
5954/email-unsubscribe
Open

feat: email unsubscribe and settings link#6340
matzduniuk wants to merge 12 commits into
mainfrom
5954/email-unsubscribe

Conversation

@matzduniuk
Copy link
Copy Markdown
Collaborator

This PR addresses #5954

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

  • Updates the rental opportunity email translation strings
  • Updates the rental opportunity email template
  • Adds the sign-in with email settings redirect link to the rental opportunity email template

How Can This Be Tested/Reviewed?

  1. Run the API setup script to apply new migrations
  2. Make sure your test user account (with the preferred email has at least one of the UserNotificationPreferences set
  3. Go to the partner's site and publish/save a published listing with a configuration matching the preferences set in step 2 to trigger the email send.
  4. On the received email, scroll down below the buttons section and click the Unsubscribe and manage email setting
  5. The user should be redirected to the jurisdiction public sign-in page with the redirectUrl=/account/notifications URL param attached
  6. Sign in as a valid user
  7. The user should be automatically rediercted to the account email notification preferences settings page

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@matzduniuk matzduniuk self-assigned this May 25, 2026
@matzduniuk matzduniuk added the 1 review needed Requires 1 more review before ready to merge label May 25, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 25, 2026

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit fd1a150
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/6a1d7daa59ef4d000808c7d0
😎 Deploy Preview https://deploy-preview-6340--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 25, 2026

Deploy Preview for bloom-angelopolis canceled.

Name Link
🔨 Latest commit 10d5c6f
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/6a1d86ea9ad2990008de8c46

@netlify
Copy link
Copy Markdown

netlify Bot commented May 25, 2026

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit fd1a150
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/6a1d7daa7d72240007333915
😎 Deploy Preview https://deploy-preview-6340--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 25, 2026

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit fd1a150
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/6a1d7daaec57d8000955dc16
😎 Deploy Preview https://deploy-preview-6340--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@emilyjablonski emilyjablonski changed the title Feat: Email unsubscribe and settings link feat: email unsubscribe and settings link May 29, 2026
Copy link
Copy Markdown
Collaborator

@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things I'm noticing, not all of which are caused by these changes, so happy to split these up if we need to! Specific to this PR, it's only the below, otherwise the redirect looks great:

  • The string is Unsubscribe and manage email setting but it should be plural settings

The below are unrelated to this change, but matter for the notifications feature as a whole. I'm 100% okay with making these into a separate ticket if you would prefer.

  • Locally if I create a new account and update notification settings, I'm unable to get any emails to send unless I remove userPreferences: { sendEmailNotifications: true } from the emailUsers query. It doesn't look like that is being set anywhere - not sure if it can be removed or if it's having some side effect I'm not aware of?
  • I'm not able to get notifications for waitlist emails. We have a check for lottery, we also need one for waitlist.
  • I'm not able to get notifications for regions in Angelopolis. I think this is because we're checking the region field, but LA is using configurableRegion (confusing I know). We should be fine to check both like const listingRegion = listing?.configurableRegion || listing?.region;
  • The listing template needs to show region (configurableRegion) if the value exists which was part of this ticket, but it's not displaying.
  • The listing template is always showing accessible marketing flyer even if one does not exist on the listing.
Image
  • We're not using consistent naming for the accessibility types. The email should match what is in the form, which is to use Hearing/Vision. The email should not say Hearing and Vision.
Image Image

@emilyjablonski emilyjablonski added needs changes The author must make changes and then re-request review before merging and removed 1 review needed Requires 1 more review before ready to merge labels May 29, 2026
@matzduniuk matzduniuk requested a review from emilyjablonski June 1, 2026 13:19
@matzduniuk matzduniuk added 1 review needed Requires 1 more review before ready to merge and removed needs changes The author must make changes and then re-request review before merging labels Jun 1, 2026
};
});

if (listing?.region) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: This still has the configurable region issue. An LA listing will have a null listing.region but may have a value in listing.configurableRegion.

sendEmailNotifications: true,
},
},
// { TODO: consider enabling this when this flag will be available to update from user account page
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Is there a future state where we expect a new flag to be available on accounts?

Copy link
Copy Markdown
Collaborator

@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tysm for all the updates!! It's just the remaining configurable region filtering piece.

There is also an unrelated issue I made a new ticket for, where on an open listing, if you just make a change and save it, it sends out the notification email again as if a new listing has been published.

@emilyjablonski emilyjablonski added needs changes The author must make changes and then re-request review before merging and removed 1 review needed Requires 1 more review before ready to merge labels Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs changes The author must make changes and then re-request review before merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants